You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2024/01/21 03:08:38 UTC
[PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
ijuma opened a new pull request, #15240:
URL: https://github.com/apache/kafka/pull/15240
All classes/traits are private and unused.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975792004
I will close this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma closed pull request #15240: MINOR: Delete KafkaCSVMetricsReporter
URL: https://github.com/apache/kafka/pull/15240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-2578377642
> I will close this for now and file a JIRA.
Have you opened the jira? If not, I'd like to open a jira for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975411816
unrelated to this PR, but it seems `KafkaMetricsReporterMBean` has unused method `startReporter` and `stopReporter` after this gets merged. Maybe we should deprecate `KafkaMetricsReporterMBean` (and `KafkaMetricsReporter`) with new Java interface. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Delete KafkaCSVMetricsReporter [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975791773
Perhaps this is actually a public interface from the days where these things didn't follow a consistent pattern. For example:
https://users.kafka.apache.narkive.com/2b0VBWUX/monitoring-kafka-metrics
So, we probably need a KIP and the removal may have to wait for 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org