You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/19 06:20:54 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
yaooqinn opened a new issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar issues.
### Describe the proposal
We have nightly Github action[1] to check compatibility with the Spark master branch as some breaking changes might be introduced upstream.
It's a good way for new contributors and those who want to get familiar with Kyuubi and Spark.
Please help us to fix those test failures, compile failures, etc.
[1] https://github.com/apache/incubator-kyuubi/actions/workflows/nightly.yml
### Task list
- [ ]
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073008776
you may need to fix test failures case by case. you can create subtasks for them and get help from the community if you need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073248628
I don't know how to fix this iusse https://github.com/apache/incubator-kyuubi/issues/2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1072989057
Hi, I want to try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073455405
>
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073832152
> @Nick-0723, If you have no idea how to fix this, shall I create an example for you? then, you can support other newly added spark data types just like I do?
Thank you, I would love it, it's a very good learning opportunity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1076984948
thanks @Nick-0723 for the effort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1077227687
thanks @Nick-0723, I'll close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
pan3793 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1072991712
@Nick-0723 thanks, assigned this ticket to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073830365
@Nick-0723, If you have no idea how to fix this, shall I create an example for you? then, you can support other newly added spark data types just like I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1077218302
Today's nightly build succeded, but I can't close this issue 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1076520254
hi @Nick-0723 ，can you check whether any test failures still exists in ci？otherwise，we can close this，and you can make PRs to support other datatypes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1076949300
>
I tested it locally and there is no failures. After today's nightly build is over, I will close this issue. The other two datatypes I'm looking at, may take a while，I'll create a issue to track it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073249796
> I don't know how to fix this iusse #2186
Spark adds new interval types, we need to support them. FYI, https://spark.apache.org/docs/latest/sql-ref-datatypes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073029682
>
- [ ] operation listener *** FAILED ***
- [ ] execute statement - select interval *** FAILED ***
- [ ] execute simple scala code *** FAILED ***
- [ ] deregister exception ttl test *** FAILED ***
- [ ] Scheduler pool *** FAILED ***
- [ ] deregister when meeting specified exception *** FAILED ***
I fixed 1, 3, 5 should I submit a pr first ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073173561
that's great，better to submit case by case if appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073250178
> > I don't know how to fix this iusse #2186
>
> Spark adds new interval types, we need to support them. FYI, https://spark.apache.org/docs/latest/sql-ref-datatypes.html
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073418291
> > I don't know how to fix this iusse #2186
>
> Spark adds new interval types, we need to support them. FYI, https://spark.apache.org/docs/latest/sql-ref-datatypes.html
I found this feature support is trackd in https://github.com/apache/incubator-kyuubi/issues/1250 , should I just fix it in the test case ? skip version spark 3.3
```scala
test("execute statement - select interval") {
// FIXME: [KYUUBI #1250]
assume(SPARK_ENGINE_MAJOR_MINOR_VERSION !== ((3, 2)))
withJdbcStatement() { statement =>
val resultSet = statement.executeQuery("SELECT interval '1' day AS col")
assert(resultSet.next())
assert(resultSet.getString("col") === "1 days")
assert(resultSet.getMetaData.getColumnType(1) === java.sql.Types.VARCHAR)
val metaData = resultSet.getMetaData
assert(metaData.getPrecision(1) === Int.MaxValue)
assert(metaData.getScale(1) === 0)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 removed a comment on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 removed a comment on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073417928
I found this feature support is trackd in #1250 , should I just fix it in the test case ? skip version spark 3.3
```scala
test("execute statement - select interval") {
// FIXME: [KYUUBI #1250]
assume(SPARK_ENGINE_MAJOR_MINOR_VERSION !== ((3, 2)))
withJdbcStatement() { statement =>
val resultSet = statement.executeQuery("SELECT interval '1' day AS col")
assert(resultSet.next())
assert(resultSet.getString("col") === "1 days")
assert(resultSet.getMetaData.getColumnType(1) === java.sql.Types.VARCHAR)
val metaData = resultSet.getMetaData
assert(metaData.getPrecision(1) === Int.MaxValue)
assert(metaData.getScale(1) === 0)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073417928
I found this feature support is trackd in #1250 , should I just fix it in the test case ? skip version spark 3.3
```scala
test("execute statement - select interval") {
// FIXME: [KYUUBI #1250]
assume(SPARK_ENGINE_MAJOR_MINOR_VERSION !== ((3, 2)))
withJdbcStatement() { statement =>
val resultSet = statement.executeQuery("SELECT interval '1' day AS col")
assert(resultSet.next())
assert(resultSet.getString("col") === "1 days")
assert(resultSet.getMetaData.getColumnType(1) === java.sql.Types.VARCHAR)
val metaData = resultSet.getMetaData
assert(metaData.getPrecision(1) === Int.MaxValue)
assert(metaData.getScale(1) === 0)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176#issuecomment-1073451405
Do not skip this, otherwise, we will maybe `never` fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed issue #2176: [Umbrella] Manage test failures with kyuubi spark nightly build
Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #2176:
URL: https://github.com/apache/incubator-kyuubi/issues/2176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org