You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/05 01:10:23 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29923: Separate CI Job to run Pytest collection check
potiuk opened a new pull request, #29923:
URL: https://github.com/apache/airflow/pull/29923
Before we attempt to run tests in parallel, we quickly check once if Pytest collection works. This is in order to avoid costly parallel test execution if that makes no sense to initialize all the parallel machines. This check used to be done in "Wait for CI Inages" step, but running it there has the undesireable side effect that it is not obvious that it's the collection that fails, also it prevents other jobs (for example static checks and docs building) from running. This means that the contributor does not get all the feedback that could be given immediately.
This PR separates the collection into separate job and only makes "test" jobs depend on it - all the other jobs that need CI image depend on "wait for CI image" one and should continue running even if pytest collection fails.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29923: Separate CI Job to run Pytest collection check
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29923:
URL: https://github.com/apache/airflow/pull/29923#issuecomment-1455022933
I've also updated the mermaid CI diagrams - you can take a look @eladkal - how diagram modification PR looks llke when you get embedded mermaid diagram (when you click "display rich diff" you are able to compare the before and after diagrams visually.
<img width="1717" alt="Screenshot 2023-03-05 at 09 18 56" src="https://user-images.githubusercontent.com/595491/222949798-c7e064f9-60b0-4285-a6f0-d6b9e9ed3797.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #29923: Separate CI Job to run Pytest collection check
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #29923:
URL: https://github.com/apache/airflow/pull/29923#issuecomment-1456731336
Love this one :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29923: Separate CI Job to run Pytest collection check
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29923:
URL: https://github.com/apache/airflow/pull/29923#issuecomment-1455015964
This one will be very helpful when things like "new dependency release" breaking test imports - only real unit tests will be affected and it will be clear that test collection is the culprit if that's the case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29923: Separate CI Job to run Pytest collection check
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29923:
URL: https://github.com/apache/airflow/pull/29923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org