[jira] [Comment Edited] (RATIS-345) Watch requests should bypass sliding window

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777452#comment-16777452 ] 

Tsz Wo Nicholas Sze edited comment on RATIS-345 at 2/26/19 1:07 AM:
--------------------------------------------------------------------

Thanks [~ljain].

# ConcurrentHashMap does not protect iteration so that I have changed it to HashMap and synchronized all the accesses.
# Good point!  It turns out the code is simpler if not try to reusing the asyc code for unordered async.

Here is a new patch: r345_20190225.patch 


was (Author: szetszwo):
Thanks [~ljain].

# ConcurrentHashMap does not protect iteration so that I have changed it to HashMap and synchronized all the accesses.

# Good point!  It turns out the code is simpler if not try to reusing the asyc code for unordered async.

Here is a new patch: r345_20190225.patch 

> Watch requests should bypass sliding window
> -------------------------------------------
>
>                 Key: RATIS-345
>                 URL: https://issues.apache.org/jira/browse/RATIS-345
>             Project: Ratis
>          Issue Type: Bug
>          Components: client, server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r345_20190128.patch, r345_20190130.patch, r345_20190131.patch, r345_20190201.patch, r345_20190202.patch, r345_20190220.patch, r345_20190221.patch, r345_20190225.patch
>
>
> Watch requests are special read-only requests.  Once the watch condition is satisfied, it should be returned immediately.  It should not wait for the earlier requests, if there are any.
> Currently, the watch requests are put in the sliding window so that it won't return until all earlier requests have been returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)