You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/25 13:36:49 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
weizhouapache opened a new pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165
### Description
This PR fixes #5548
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#discussion_r835576944
##########
File path: plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
##########
@@ -100,8 +100,11 @@
public class SAMLUtils {
public static final Logger s_logger = Logger.getLogger(SAMLUtils.class);
+ static final String charset = "abcdefghijklmnopqrstuvwxyz";
Review comment:
@rohityadavcloud
I have checked hundreds of request IDs, all are composed by digits (0 to 9) or lower case alphabet (a to z).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kohrar commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
kohrar commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1082630360
That looks great. Thank-you for implementing the fix, @weizhouapache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1079098465
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1079565173
<b>Trillian test result (tid-3727)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35587 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6165-t3727-kvm-centos7.zip
Smoke tests completed. 77 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.75 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.13 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.22 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.09 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 51.34 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 31.99 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 76.89 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#discussion_r835356716
##########
File path: plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
##########
@@ -100,8 +100,11 @@
public class SAMLUtils {
public static final Logger s_logger = Logger.getLogger(SAMLUtils.class);
+ static final String charset = "abcdefghijklmnopqrstuvwxyz";
Review comment:
should we also have A-Z (i.e. a-z in upper case too) @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1079160955
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1081560444
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1079140184
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1081710943
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1081710654
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#issuecomment-1082314401
<b>Trillian test result (tid-3750)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31981 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6165-t3750-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org