You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/03 13:40:00 UTC
[jira] [Work logged] (HADOOP-17295) Move dedicated pre-logging
statements into existing logging guards
[ https://issues.apache.org/jira/browse/HADOOP-17295?focusedWorklogId=494283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-494283 ]
ASF GitHub Bot logged work on HADOOP-17295:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/20 13:39
Start Date: 03/Oct/20 13:39
Worklog Time Spent: 10m
Work Description: coder-chenzhi opened a new pull request #2358:
URL: https://github.com/apache/hadoop/pull/2358
I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create this PR to fix them.
These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 494283)
Remaining Estimate: 0h
Time Spent: 10m
> Move dedicated pre-logging statements into existing logging guards
> ------------------------------------------------------------------
>
> Key: HADOOP-17295
> URL: https://issues.apache.org/jira/browse/HADOOP-17295
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chen Zhi
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create a PR to fix them.
> These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org