You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/02 02:19:10 UTC
Re: Review Request 12119: Moved master/slave HTTP route handlers into inner
class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12119/#review22636
-----------------------------------------------------------
src/slave/http.cpp
<https://reviews.apache.org/r/12119/#comment46334>
Looks like you missed this one.
- Ben Mahler
On June 26, 2013, 8:59 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12119/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:59 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> BenM and I had briefly discussed this once. In the end this is less code and I much prefer the encapsulation!
>
>
> Diffs
> -----
>
> src/Makefile.am 933743593d8de2fcc412d2f771a4cbc1e6fd2884
> src/master/http.hpp 9eb0a31defbe15e32cbc8e611305f1d1bac80ced
> src/master/http.cpp 47471d6881fa1b101cdeb3fb48a59712490267e9
> src/master/master.hpp 86c5232d57e9e86e13acf48b68f1e3cf23442495
> src/master/master.cpp a0b862a4f825c00dec2b73f993fe58d8aa90812b
> src/slave/http.hpp 98014708b2f01b453ab9ab3bfc2eeebcf82b3529
> src/slave/http.cpp e362c3033f098838bf4133a208fe6381134f4d09
> src/slave/slave.hpp 3ac893309b49e23fffebb8118d427e5d89d61a86
> src/slave/slave.cpp 9985f14467ca0aa7faf83e602e1d8f1c2219dfc0
>
> Diff: https://reviews.apache.org/r/12119/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 12119: Moved master/slave HTTP route handlers into inner
class.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 2, 2013, 12:19 a.m., Ben Mahler wrote:
> > src/slave/http.cpp, line 38
> > <https://reviews.apache.org/r/12119/diff/1/?file=311261#file311261line38>
> >
> > Looks like you missed this one.
Thanks for the fix Ben.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12119/#review22636
-----------------------------------------------------------
On June 26, 2013, 8:59 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12119/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:59 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> BenM and I had briefly discussed this once. In the end this is less code and I much prefer the encapsulation!
>
>
> Diffs
> -----
>
> src/Makefile.am 933743593d8de2fcc412d2f771a4cbc1e6fd2884
> src/master/http.hpp 9eb0a31defbe15e32cbc8e611305f1d1bac80ced
> src/master/http.cpp 47471d6881fa1b101cdeb3fb48a59712490267e9
> src/master/master.hpp 86c5232d57e9e86e13acf48b68f1e3cf23442495
> src/master/master.cpp a0b862a4f825c00dec2b73f993fe58d8aa90812b
> src/slave/http.hpp 98014708b2f01b453ab9ab3bfc2eeebcf82b3529
> src/slave/http.cpp e362c3033f098838bf4133a208fe6381134f4d09
> src/slave/slave.hpp 3ac893309b49e23fffebb8118d427e5d89d61a86
> src/slave/slave.cpp 9985f14467ca0aa7faf83e602e1d8f1c2219dfc0
>
> Diff: https://reviews.apache.org/r/12119/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>