You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by rk...@apache.org on 2018/06/13 08:51:23 UTC

zeppelin git commit: [ZEPPELIN-3492] The paragraph's table does not scroll if there is a large cell

Repository: zeppelin
Updated Branches:
  refs/heads/master 6137c2a81 -> f22bbde1c


[ZEPPELIN-3492] The paragraph's table does not scroll if there is a large cell

When scrolling (with the mouse wheel), the contents of the table jump and do not scroll down. The scroll bar is working fine. Often this happens if the table has a cell with a large height.

[Bug Fix]

[ZEPPELIN-3492](https://issues.apache.org/jira/browse/ZEPPELIN-3492)

[Text](https://github.com/apache/zeppelin/files/2030555/paragraphText.txt) of the paragraph (python interpreter)

![peek_before](https://user-images.githubusercontent.com/30798933/40417963-c3d158a4-5e89-11e8-8c68-5a0397281c75.gif)

![peek_after](https://user-images.githubusercontent.com/30798933/40417977-ccf60f1a-5e89-11e8-88b3-c7855a198e2d.gif)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Savalek <de...@mail.ru>

Closes #2982 from Savalek/ZEPPELIN-3492 and squashes the following commits:

06ef2e616 [Savalek] [ZEPPELIN-3492] fix paragraph's table scroll

Change-Id: I22218a65345f7e84d65bd50b0d110ceb86b8ecbf


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f22bbde1
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f22bbde1
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f22bbde1

Branch: refs/heads/master
Commit: f22bbde1ce83b10f0821e26168cf6cd058b94486
Parents: 6137c2a
Author: Savalek <de...@mail.ru>
Authored: Wed May 23 12:58:30 2018 +0300
Committer: Renjith Kamath <rk...@apache.org>
Committed: Wed Jun 13 14:21:16 2018 +0530

----------------------------------------------------------------------
 zeppelin-web/src/app/visualization/builtins/visualization-table.js | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f22bbde1/zeppelin-web/src/app/visualization/builtins/visualization-table.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-table.js b/zeppelin-web/src/app/visualization/builtins/visualization-table.js
index 831bf95..30d3291 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-table.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-table.js
@@ -153,6 +153,7 @@ export default class TableVisualization extends Visualization {
       saveTreeView: true,
       saveFilter: true,
       saveSelection: false,
+      customScroller: (uiGrid) => uiGrid.on('wheel', (event) => event.stopPropagation()),
     };
 
     return gridOptions;