You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/07/03 15:11:51 UTC

[GitHub] flink pull request #4249: [FLINK-7070] Use properly built custom jar in Scal...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4249

    [FLINK-7070] Use properly built custom jar in ScalaShellITCase

    Before, the external jar loading tests where using the flink-ml jar
    without the scala shell package actually declaring this as a dependency.
    Now we built our own jar and have no unlisted dependencies anymore.
    
    R: @zentol 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-7070-fix-scala-shell-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4249
    
----
commit c4e1d3a32a1ec833903a7a8ca479f3578d93b157
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-07-03T15:09:25Z

    [FLINK-7070] Use properly built custom jar in ScalaShellITCase
    
    Before, the external jar loading tests where using the flink-ml jar
    without the scala shell package actually declaring this as a dependency.
    Now we built our own jar and have no unlisted dependencies anymore.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4249: [FLINK-7070] Use properly built custom jar in ScalaShellI...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4249
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4249: [FLINK-7070] Use properly built custom jar in ScalaShellI...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4249
  
    +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4249: [FLINK-7070] Use properly built custom jar in Scal...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---