You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/17 10:08:11 UTC

[GitHub] [kafka] dengziming opened a new pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

dengziming opened a new pull request #11785:
URL: https://github.com/apache/kafka/pull/11785


   *More detailed description of your change*
   Remove unused AdminZkClient in MetadataSupport
   
   *Summary of testing strategy (including rationale)*
   QA
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043738331


   @dengziming , could you please rebase to the latest trunk and trigger jenkins build again? I'd like to confirm it won't break any tests. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043989800


   Confirmed this `adminZkClient` is not used anywhere else. So, it makes sense to remove it. If the `ZkSupport` object needs to create `adminZkClient`, it can create an `AdminZkClient` anytime via the `zkClient` class member. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1042863147


   cc @showuon 🤝


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1042936603


   I'll check it tomorrow. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon merged pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
showuon merged pull request #11785:
URL: https://github.com/apache/kafka/pull/11785


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043982299


   Failed tests are unrelated.
   ```
       Build / ARM / kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives()
       Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPathToJsonFile, Security=PLAINTEXT
       Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT
       Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPathToJsonFile, Security=PLAINTEXT
       Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 8 and Scala 2.12 / kafka.api.DelegationTokenEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #11785: MINOR: Remove unused AdminZkClient in MetadataSupport

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043741005


   @showuon Aha, I just rebased it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org