[jira] [Commented] (HADOOP-7948) Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179047#comment-13179047 ] 

Hadoop QA commented on HADOOP-7948:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12509343/HADOOP-7948.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/493//console

This message is automatically generated.
                
> Shell scripts created by hadoop-dist/pom.xml to build tar do not properly propagate failure
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7948
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7948
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>         Environment: OSX
>            Reporter: Michajlo Matijkiw
>            Priority: Minor
>         Attachments: HADOOP-7948.patch
>
>
> The run() function, as defined in dist-layout-stitching.sh and dist-tar-stitching, created in hadoop-dist/pom.xml, does not properly propagate the error code of a failing command.  See the following:
> {code}
>     ...
>     "${@}"                 # call fails with non-zero exit code
>     if [ $? != 0 ]; then   
>         echo               
>         echo "Failed!"     
>         echo               
>         exit $?            # $?=result of echo above, likely 0, thus exit with code 0
>     ...
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira