[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492238398



##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception {
         }
 
         // convert raw JSON into user-friendly output
-        solrHome = (String)systemInfo.get("solr_home");
-        if (solrHome == null)
-          solrHome = configsetsDir.getParentFile().getAbsolutePath();
+        coreRootDirectory = (String)systemInfo.get("solr_core_root");

Review comment:
       Can you help my understand where exactly solr_core_root is populated?  I don't see it in SystemInfoHandler which I presume populates the response for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org