You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/09/20 00:35:19 UTC

Review Request: Use std:cerr instead of VLOG in launcher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7183/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Summary (updated)
-----------------

Use std:cerr instead of VLOG in launcher


Description (updated)
-------

See summary.

We need this to avoid forked executor processes blocking on glog file lock(s).


Diffs (updated)
-----

  src/launcher/launcher.cpp 2405f2f 

Diff: https://reviews.apache.org/r/7183/diff/


Testing (updated)
-------

[vinod@tw-172-25-27-97 ~/workspace/apache/mesos/build (fix_executor_lock)]$ for (( i=0; i<=20; i++ )); do GLOG_v=1 ./src/test-framework local; done


Thanks,

Vinod Kone

Re: Review Request: Use std:cerr instead of VLOG in launcher

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7183/#review11722
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 19, 2012, 10:35 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7183/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 10:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> We need this to avoid forked executor processes blocking on glog file lock(s).
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 2405f2f 
> 
> Diff: https://reviews.apache.org/r/7183/diff/
> 
> 
> Testing
> -------
> 
> [vinod@tw-172-25-27-97 ~/workspace/apache/mesos/build (fix_executor_lock)]$ for (( i=0; i<=20; i++ )); do GLOG_v=1 ./src/test-framework local; done
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>