You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/16 22:50:55 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #416: Partial backport of Tiny improvements PR#414 to 2.5.x:

JCgH4164838Gh792C124B5 opened a new pull request #416:
URL: https://github.com/apache/struts/pull/416


   Partial backport of L. Lenart's PR#414 to 2.5.x:
   - Improve `Dispatcher` `getLocale()` handling if running in AppEngine.
   - Implemented the same improvement to the `defaultLocale` logic path within `getLocale()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #416: Partial backport of Tiny improvements PR#414 to 2.5.x:

Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #416:
URL: https://github.com/apache/struts/pull/416#issuecomment-629716479


   Hello Apache Struts Team.
   
   Looking at #414 it seems like the Dispatcher change there would make sense for Struts 2.5.x as well.
   
   So ... this PR is a partial backport for that change, with a small addition to the new logic @lukaszlenart applied to 2.6 for the other path in the if block.
   
   If this change looks OK, and makes sense for 2.5.x, we can probably cherry-pick the small addition back into 2.6 as well.
   
   Let me know what the team thinks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart merged pull request #416: Partial backport of Tiny improvements PR#414 to 2.5.x:

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #416:
URL: https://github.com/apache/struts/pull/416


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls commented on pull request #416: Partial backport of Tiny improvements PR#414 to 2.5.x:

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #416:
URL: https://github.com/apache/struts/pull/416#issuecomment-629717109


   
   [![Coverage Status](https://coveralls.io/builds/30837471/badge)](https://coveralls.io/builds/30837471)
   
   Coverage decreased (-0.006%) to 47.076% when pulling **59a6cbf6cafb90427b19b756a46c8b37a5f6990f on JCgH4164838Gh792C124B5:Partial_Backport_LL_tiny-improvements** into **19802b0614255c14da7e940979995bd92a279af3 on apache:struts-2-5-x**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org