You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/11/17 17:37:48 UTC

[GitHub] [trafficserver] duke8253 opened a new issue #7327: Remove unnecessary check when scheduling

duke8253 opened a new issue #7327:
URL: https://github.com/apache/trafficserver/issues/7327


   While reviewing some other code I noticed in a previous PR #6103, I added this check in `EThread::schedule` to keep it consistent with the behavior in `EventProcessor::schedule`.
   https://github.com/apache/trafficserver/blob/master/iocore/eventsystem/P_UnixEThread.h#L99
   
   But since we are setting `e->ethread = this`, this check becomes redundant. 
   https://github.com/apache/trafficserver/blob/master/iocore/eventsystem/P_UnixEThread.h#L82
   
   And upon further consideration, I think it is better to revert to the old behavior to use `enqueue` rather than `enqueue_local` since there is a method dedicated to that `EThread::schedule_local`. 
   
   This may or may not have performance issues, we'll need further testing to verify that. However the problem addressed in #6103 isn't affected by this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] duke8253 closed issue #7327: Remove unnecessary check when scheduling

Posted by GitBox <gi...@apache.org>.

duke8253 closed issue #7327:
URL: https://github.com/apache/trafficserver/issues/7327


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] duke8253 commented on issue #7327: Remove unnecessary check when scheduling

Posted by GitBox <gi...@apache.org>.

duke8253 commented on issue #7327:
URL: https://github.com/apache/trafficserver/issues/7327#issuecomment-730503915


   Closing this for now, need to rethink through this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org