[jira] Commented: (LOG4PHP-117) LoggerConfiguratorIni::configure() and unexptected results from error_get_last()

["Christian Grobmeier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869499#action_12869499 ] 

Christian Grobmeier commented on LOG4PHP-117:
---------------------------------------------

Actually this is a pretty bad behaviour of Log4PHP. Thanks for bringing this up.
I am not sure if triggering an empty error is what we should do here.

I am also not sure if we really need the error_get_last. If we have false properties or a count of 0, then its very clear that its something wrong with the properties file. We can raise the exception without knowing the exact case. Maybe this would be enough:

throw new LoggerException("LoggerConfiguratorIni could not parse properties file: ".$url);

and dropping of trigger_error and error_get_last


What do you think? 

> LoggerConfiguratorIni::configure() and unexptected results from error_get_last()
> --------------------------------------------------------------------------------
>
>                 Key: LOG4PHP-117
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-117
>             Project: Log4php
>          Issue Type: Bug
>          Components: Code
>    Affects Versions: 2.1
>            Reporter: Maciej Mazur
>         Attachments: error_get_last_patch
>
>
> This apply to src/main/php/configurators/LoggerConfiguratorIni.php
> If you invoke LoggerConfiguratorIni::configure() after there was any notice or warning in your PHP script, then LoggerConfiguratorIni will throw an exception even if there is no need (propably terminating execution)
> 284	        public function configure(LoggerHierarchy $hierarchy, $url = '') {
> 285	                $properties = @parse_ini_file($url);
> 286	                if ($properties === false || count($properties) == 0) {
> 287	                        $error = error_get_last();
> 288	                    throw new LoggerException("LoggerConfiguratorIni: ".$error['message']);
> 289	                }
> 290	                return $this->doConfigureProperties($properties, $hierarchy);
> 291	        }
> In line 287 it is checked if there was any error triggered by function parse_ini_file(). Unfortunately function error_get_last() doesn't return an error triggered by execution of the last function. It returnes an error that is most recent in global, even if it was already catched and taken care of. This is because there is no way to reset the state of the last error. It returns always the last triggered error. (http://www.php.net/manual/en/function.error-get-last.php#83608)
> I attached the patch that "solves" this by triggering an empty error before parse_ini_file(), and the it is checked if the error has an empty message:
>         public function configure(LoggerHierarchy $hierarchy, $url = '') {
>                 @trigger_error('');
>                 $properties = @parse_ini_file($url);
>                 if ($properties === false || count($properties) == 0) {
>                         $error = error_get_last();
>                         if ($error['message'] != '') {
>                                 throw new LoggerException("LoggerConfiguratorIni: ".$error['message']);
>                         }
>                 }
>                 return $this->doConfigureProperties($properties, $hierarchy);
>         }
> This not very pretty but it works

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.