[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8840: make userleds work on Arduino Due

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8840:
URL: https://github.com/apache/nuttx/pull/8840#discussion_r1141825035


##########
boards/arm/sam34/arduino-due/README.txt:
##########
@@ -861,3 +861,9 @@ Configuration sub-directories
 
        STATUS:
        2013-7-2:  TSC is not responding.  All 0's received on SPI.
+
+  nsh-leds:

Review Comment:
   Indentation in this block is different from above



##########
boards/arm/sam34/arduino-due/src/sam_bringup.c:
##########
@@ -117,5 +125,19 @@ int sam_bringup(void)
 #endif
 
   UNUSED(ret);

Review Comment:
   Let's move `UNUSED(ret);` after `#ifdef HAVE_LEDS` block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org