[jira] [Commented] (ARTEMIS-3186) enable option "Create queue" more often

["Erwin Dondorp (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475326#comment-17475326 ] 

Erwin Dondorp commented on ARTEMIS-3186:
----------------------------------------

I'm preparing a PR for this and have this mostly working.

[~jbertram]
(not sure whether this question belongs in the mailing list; also just picked you to ask this first)
The fact is that the nodes {{queues}} and {{anycast}}/{{multicast}} (and also some others) in the tree are not connected to JMX objects.
So, instead of logic on the jmx properties {{component}}/{{subcomponent}} (in {{navigation.js}}), I used logic on {{folderNames}} in function {{shouldShowCreateQueueTab}} to determine (additional) visibility of tab {{Create queue}}.
That leads to 2 questions:
1) is that an acceptable practice?
2) (if acceptable) should that practice then also be applied to other {{shouldShow...}} functions for consistency?

> enable option "Create queue" more often
> ---------------------------------------
>
>                 Key: ARTEMIS-3186
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3186
>             Project: ActiveMQ Artemis
>          Issue Type: Wish
>          Components: Web Console
>    Affects Versions: 2.17.0
>            Reporter: Erwin Dondorp
>            Priority: Minor
>
> The option "Create queue" is only enabled in the gui when an address is selected.
> It makes sense to enable it also when:
> * the item "queues" under the address is selected; or
> * the item "multicast" or "anycast" under the address is selected (but not when "divert" is selected). In that case, the "Routing type" can even be prefilled with the already selected routing type.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)