[jira] [Commented] (PARQUET-485) Decouple data page delimiting from column reader / scanner classes, create test fixtures

["Wes McKinney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126474#comment-15126474 ] 

Wes McKinney commented on PARQUET-485:
--------------------------------------

See https://github.com/apache/parquet-cpp/pull/32. This is ready for review and merge after addressing CR comments

> Decouple data page delimiting from column reader / scanner classes, create test fixtures
> ----------------------------------------------------------------------------------------
>
>                 Key: PARQUET-485
>                 URL: https://issues.apache.org/jira/browse/PARQUET-485
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>
> It is difficult to test the column reader classes with mock data because the data page resolution is tightly coupled to the actual file format layout in {{ColumnReader::ReadNewPage}}.
> I plan to separate these concerns, so that the column readers can be tested with a sequence of data pages encoded in memory, but never actually assembled into a file stream layout with thrift-serialized page headers. Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)