You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/08/02 03:33:57 UTC

Re: Review Request 23959: ACCUMULO-2694 Changes for 1.6 branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23959/
-----------------------------------------------------------

(Updated Aug. 2, 2014, 1:33 a.m.)


Review request for accumulo and Josh Elser.


Changes
-------

updated new IT to check for balancing earlier and then use back off.


Bugs: ACCUMULO-2694
    https://issues.apache.org/jira/browse/ACCUMULO-2694


Repository: accumulo


Description (updated)
-------

These are the changes needed on 1.6 after merging the fix for the 1.5 branch forward.

    - manually redo changes to Master
    - convert python functional test to an IT
    -- Add programmatic access to MasterMonitorInfo to MiniAccumuloClusterImpl
    -- Make SystemCredentials work with MiniAccumuloClusterImpl


The change to log4j.properties in minicluster is just changing from CR to LF


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/AccumuloSecurityException.java 06b148d79fa6f97aedff115ad21d7459f17567f6 
  minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java 9a8efa60f7418b7b3ade766e72eb6b219063eb20 
  minicluster/src/test/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImplTest.java 99f8d7d62b687dd8c9ccbb7f0879885ad3a8cf39 
  minicluster/src/test/resources/log4j.properties b5efe8d6e29d14d4044c9b60c800f0e9d7cc85b3 
  server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java ec3371c90f98ae0443ee788062e332f472d3cb78 
  server/base/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 1fcab4681c32b20d04d8ab9e72d6a61eb6bdddf0 
  server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java 5bd16325bad7903f66838dac0fb6ff2bfd2d580a 
  server/base/src/main/java/org/apache/accumulo/server/security/SystemCredentials.java 767ed2589000e60bae63c106834b2493a7f39404 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 30b1f2e799b5f9a981ad758203a4abd442fa28f6 
  test/pom.xml f3cc927c6cc724450109a7baa6a96b3278c3f86b 
  test/src/test/java/org/apache/accumulo/test/functional/BalanceInPresenceOfOfflineTableIT.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23959/diff/


Testing
-------

Ran new IT prior to Master changes: test fails; ran new IT after Master changes: test passes.


Thanks,

Sean Busbey


Re: Review Request 23959: ACCUMULO-2694 Changes for 1.6 branch

Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23959/#review49419
-----------------------------------------------------------

Ship it!


Ship It!

- Josh Elser


On Aug. 2, 2014, 1:33 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23959/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 1:33 a.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> These are the changes needed on 1.6 after merging the fix for the 1.5 branch forward.
> 
>     - manually redo changes to Master
>     - convert python functional test to an IT
>     -- Add programmatic access to MasterMonitorInfo to MiniAccumuloClusterImpl
>     -- Make SystemCredentials work with MiniAccumuloClusterImpl
> 
> 
> The change to log4j.properties in minicluster is just changing from CR to LF
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/AccumuloSecurityException.java 06b148d79fa6f97aedff115ad21d7459f17567f6 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java 9a8efa60f7418b7b3ade766e72eb6b219063eb20 
>   minicluster/src/test/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImplTest.java 99f8d7d62b687dd8c9ccbb7f0879885ad3a8cf39 
>   minicluster/src/test/resources/log4j.properties b5efe8d6e29d14d4044c9b60c800f0e9d7cc85b3 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java ec3371c90f98ae0443ee788062e332f472d3cb78 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 1fcab4681c32b20d04d8ab9e72d6a61eb6bdddf0 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java 5bd16325bad7903f66838dac0fb6ff2bfd2d580a 
>   server/base/src/main/java/org/apache/accumulo/server/security/SystemCredentials.java 767ed2589000e60bae63c106834b2493a7f39404 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java 30b1f2e799b5f9a981ad758203a4abd442fa28f6 
>   test/pom.xml f3cc927c6cc724450109a7baa6a96b3278c3f86b 
>   test/src/test/java/org/apache/accumulo/test/functional/BalanceInPresenceOfOfflineTableIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23959/diff/
> 
> 
> Testing
> -------
> 
> Ran new IT prior to Master changes: test fails; ran new IT after Master changes: test passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>