Java 1.4 and 1.5

[Dave Roberts <da...@saaconsultants.com>]

We currently have the situation where the project builds and works
with either JVM, although 1.5 is required for the SSL tests.

Due to the need for 1.4 compatibility, we're using the 1.0.x code
branch of MINA, the latest being 1.0.7.

It's currently not possible to switch to the 1.1.x branch of MINA
without making some code changes, to make use of the
java.util.concurrent classes, rather than the ones provided in the
backport-util-concurrent JAR.

Certainly for me this has now become a problem where I've needed to
change the FTP Server code to move forwards and make use of MINA
1.1.4.  Obviously this isn't a patch I can submit, as it will break
our Java 1.4 compatibility.

We have 3 options:-

1) Keep the code as it is, and remain compatible with both Java 1.4
and Java 1.5.

2) Drop Java 1.4, change the code to use MINA 1.1.x and remove the
dependency on backport-util-concurrent.

3) Create a 1.4 branch in Subversion. Keep the 1.4 branch as a
maintenance release where only bugs are fixed, and the TRUNK version
will move to Java 1.5, MINA 1.1.x and have all the new development.

Re: Java 1.4 and 1.5

[Niklas Gustavsson <ni...@protocol7.com>]

Dave Roberts wrote:
> 3) Create a 1.4 branch in Subversion. Keep the 1.4 branch as a
> maintenance release where only bugs are fixed, and the TRUNK version
> will move to Java 1.5, MINA 1.1.x and have all the new development.

Since everyone so far has agreed on option 3, and no one has objected, 
I'll go ahead and make the changes. As I said before, I will continue 
accepting patches (bug fixes or improvements) for the 1.4 branch but 
won't be doing any active development myself.

As part of this action, I will drop the IO listener from trunk and will 
restructure our code to fully make use of MINA. This will lead to a a 
period of destabilization. Hope you all okay with that, bug reports will 
of course be welcome :-)

/niklas

RE: Java 1.4 and 1.5

[Pierre Huttin <pi...@huttin.com>]

I'm also agree to choose the option 3

---
Pierre Huttin
pierre@huttin.com
 
ECM/Documentum Consultant
> -----Original Message-----
> From: Dave Roberts [mailto:dave.roberts@saaconsultants.com]
> Sent: Thursday, November 22, 2007 3:38 PM
> To: ftpserver-dev@incubator.apache.org
> Subject: Re: Java 1.4 and 1.5
> 
> Niklas Gustavsson wrote:
> > That was excellent timing, I had a draft of pretty much the same email
> > sitting waiting for completion tonight :-)
> 
> That's great!  I'm pleased you were thinking in the same direction also.
> 
> >> 3) Create a 1.4 branch in Subversion.
> 
> This gets my vote.
> 
> Whether the branch is for bug fixes only or continues to get new
> development is actually irrelevant and I should have left that part out.

Re: Java 1.4 and 1.5

[Dave Roberts <da...@saaconsultants.com>]

Niklas Gustavsson wrote:
> That was excellent timing, I had a draft of pretty much the same email 
> sitting waiting for completion tonight :-)

That's great!  I'm pleased you were thinking in the same direction also.

>> 3) Create a 1.4 branch in Subversion. 

This gets my vote.

Whether the branch is for bug fixes only or continues to get new
development is actually irrelevant and I should have left that part out.

Re: Java 1.4 and 1.5

[Niklas Gustavsson <ni...@protocol7.com>]

That was excellent timing, I had a draft of pretty much the same email 
sitting waiting for completion tonight :-)

My vote is on 3 and I'm willing to continue apply patches for the 1.4 
branch. But, I would like to drop 1.4 support for trunk since there are 
tons of places where we could remove our somewhat crappy code for much 
better patterns introduced by MINA.

If we agree on this way forward, I will make the changes this weekend.

/niklas

Dave Roberts wrote:
> We currently have the situation where the project builds and works
> with either JVM, although 1.5 is required for the SSL tests.
> 
> Due to the need for 1.4 compatibility, we're using the 1.0.x code
> branch of MINA, the latest being 1.0.7.
> 
> It's currently not possible to switch to the 1.1.x branch of MINA
> without making some code changes, to make use of the
> java.util.concurrent classes, rather than the ones provided in the
> backport-util-concurrent JAR.
> 
> Certainly for me this has now become a problem where I've needed to
> change the FTP Server code to move forwards and make use of MINA
> 1.1.4.  Obviously this isn't a patch I can submit, as it will break
> our Java 1.4 compatibility.
> 
> We have 3 options:-
> 
> 1) Keep the code as it is, and remain compatible with both Java 1.4
> and Java 1.5.
> 
> 2) Drop Java 1.4, change the code to use MINA 1.1.x and remove the
> dependency on backport-util-concurrent.
> 
> 3) Create a 1.4 branch in Subversion. Keep the 1.4 branch as a
> maintenance release where only bugs are fixed, and the TRUNK version
> will move to Java 1.5, MINA 1.1.x and have all the new development.
> 
> 
> 
>