You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/03/23 21:10:37 UTC
[PR] [SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema [spark]
Yicong-Huang opened a new pull request, #54962:
URL: https://github.com/apache/spark/pull/54962
### What changes were proposed in this pull request?
Fix the unit test for 0-column schema conversion to actually verify the bug fix from SPARK-55600.
The existing test used a 0-row DataFrame to test 0-column conversion, which trivially passed (`num_rows == 0`) without exercising the fix. This replaces it with a 3-row DataFrame so the assertion (`num_rows == 3`) properly validates that row count is preserved.
Also removes the stale `TODO(SPARK-55350)` comment.
### Why are the changes needed?
The test was not verifying the intended behavior.
### Does this PR introduce _any_ user-facing change?
No. Test-only change.
### How was this patch tested?
```
python -m pytest python/pyspark/sql/tests/test_conversion.py::PandasToArrowConversionTests::test_convert -xvs
```
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #54962: [SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema
URL: https://github.com/apache/spark/pull/54962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54962:
URL: https://github.com/apache/spark/pull/54962#issuecomment-4114779432
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org