You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/28 21:48:38 UTC
[GitHub] [airflow] zachliu opened a new issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
zachliu opened a new issue #21878:
URL: https://github.com/apache/airflow/issues/21878
### Apache Airflow version
2.2.4 (latest released)
### What happened
After setting up alert emails using AWS SES as instructed [here](https://airflow.apache.org/docs/apache-airflow/stable/howto/email-config.html#send-email-using-aws-ses), I received the following error message:
```
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/airflow/models/taskinstance.py", line 2103, in email_alert
send_email(self.task.email, subject, html_content)
File "/usr/local/lib/python3.8/site-packages/airflow/utils/email.py", line 57, in send_email
return backend(
TypeError: send_email() got multiple values for argument 'from_email'
```
### What you expected to happen
the `send_email` method in https://github.com/apache/airflow/blob/d94fa378305957358b910cfb1fe7cb14bc793804/airflow/providers/amazon/aws/utils/emailer.py#L25-L37 doesn't match the invocation of the `backend` method in https://github.com/apache/airflow/blob/ee9049c0566b2539a247687de05f9cffa008f871/airflow/utils/email.py#L57-L70
in the former (provider-amazon), the `from_email` is the first positional argument. However in the latter (main airflow), `from_email` is misplaced as a keyword argument.
### How to reproduce
1. Use `Airflow 2.2.4` with `providers-amazon/3.0.0`
2. Observe the log from a failed DAG
### Operating System
Amazon Linux 2
### Versions of Apache Airflow Providers
apache-airflow-providers-amazon 3.0.0
### Deployment
Other Docker-based deployment
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055169199
Ah yeah. My fix has not yet been released when 2.2.4 has been released simply. It will be fixed in the release I am about to release today. Maybe (I will see how many changes we have) since this is quite an important problem, we might even update constraints and re-generate images for 2.2.4 to include the new amazon provider with the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055160390
Ah no... I see the problem :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055532429
Yeah. I merge a few last changes and I will be ready to prepare the relase. Loking forward to helping testing it @zachliu :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1068136442
It's being voted and tested now https://github.com/apache/airflow/issues/22264.
Since you are interested int the release @repl-mike-roest could you please test the release candidate and report back? Since the software you get is free, and you apparenly are very interested in getting it out, testing it and confirming tha the fix is working is the best way to pay back to the communiy. Can I count on your help with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
zachliu commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055512933
@potiuk great, thanks! eagerly waiting for `providers-amazon-3.0.1` :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055158889
I beleive that the incompatibilities have been fixed in 3.0.0 (the issue was raised here https://github.com/apache/airflow/issues/21671 and I thought I fixed it in https://github.com/apache/airflow/pull/21681).
What is exactly your configuration @zachliu? Do you have maybe a connection setup with "from_email" extra? That could explain the duplicate from_email entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055158889
I beleive that it has been fixed in 3.0.0 (the issue was raised here https://github.com/apache/airflow/issues/21671 and I thought I fixed it in https://github.com/apache/airflow/pull/21681).
What is exactly your configuration @zachliu? Do you have maybe a connection setup with "from_email" extra? That could explain the duplicate from_email entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #21878:
URL: https://github.com/apache/airflow/issues/21878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1068137024
See #22264 - it contains information about the release candidate and link to instructions on how to test it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1054727172
Looks like this is introduced in 1543dc28f4a2f1631dfaedd948e646a181ccf7ee. I think we should fix this (by moving the `from_email` argument to the correct place), and also use this chance to 1. convert `send_email` _caller_ to always use keyword arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1055169782
Closing as duplicate of #21681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repl-mike-roest commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
repl-mike-roest commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1068097407
@potiuk any update on a release to get this fix out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repl-mike-roest commented on issue #21878: Function arg list mismatch between provider code and main code when using AWS SES
Posted by GitBox <gi...@apache.org>.
repl-mike-roest commented on issue #21878:
URL: https://github.com/apache/airflow/issues/21878#issuecomment-1068139540
Awesome yep @potiuk let me see what I can do to help out on things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org