You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/14 03:16:02 UTC

[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10809: [Bug][Rollup] fix fe crash because npe on rollupBatchTask

BiteTheDDDDt commented on code in PR #10809:
URL: https://github.com/apache/doris/pull/10809#discussion_r920713657


##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -540,7 +540,11 @@ protected boolean cancelImpl(String errMsg) {
 
     private void cancelInternal() {
         // clear tasks if has
-        AgentTaskQueue.removeBatchTask(rollupBatchTask, TTaskType.ALTER);
+        if (rollupBatchTask != null) {

Review Comment:
   > rollup batch task should not be null？it should be empty？how to reproduce it？it seems a little serious rollup batch task now will be always initialized, so it is so strange
   
   Seem this job object is read from `JournalEntity`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org