You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2007/07/31 16:22:40 UTC

svn commit: r561339 - /james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/

Author: rdonkin
Date: Tue Jul 31 07:22:39 2007
New Revision: 561339

URL: http://svn.apache.org/viewvc?view=rev&rev=561339
Log:
Stop superclass being run as a test.

Added:
    james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java
      - copied, changed from r561318, james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java
Removed:
    james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java
Modified:
    james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java
    james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java
    james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java

Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java?view=diff&rev=561339&r1=561338&r2=561339
==============================================================================
--- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java (original)
+++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java Tue Jul 31 07:22:39 2007
@@ -30,7 +30,7 @@
  * cases.  It provides basic functionality for running a protocol session
  * as a JUnit test, and failing if exceptions are thrown.
  * To create a test which reads the entire protocol session from a single
- * protocol definition file, use the {@link SimpleFileProtocolTest}.
+ * protocol definition file, use the {@link SimpleScriptedTestProtocol}.
  *
  * @author Darrell DeBoer
  * @author Andrew C. Oliver

Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java
URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java?view=diff&rev=561339&r1=561338&r2=561339
==============================================================================
--- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java (original)
+++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java Tue Jul 31 07:22:39 2007
@@ -52,7 +52,7 @@
  * </p>
  */
 public class BaseTestForAuthenticatedState
-        extends SimpleFileProtocolTest implements ImapTestConstants
+        extends SimpleScriptedTestProtocol implements ImapTestConstants
 {
     public BaseTestForAuthenticatedState( String name, HostSystem hostSystem)
     {

Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java
URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java?view=diff&rev=561339&r1=561338&r2=561339
==============================================================================
--- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java (original)
+++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java Tue Jul 31 07:22:39 2007
@@ -37,7 +37,7 @@
  * </ul>
  */
 public class BaseTestNonAuthenticatedState
-        extends SimpleFileProtocolTest
+        extends SimpleScriptedTestProtocol
 {
     public BaseTestNonAuthenticatedState( String name, HostSystem system )
     {

Copied: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java (from r561318, james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java)
URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java?view=diff&rev=561339&p1=james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java&r1=561318&p2=james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java&r2=561339
==============================================================================
--- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java (original)
+++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java Tue Jul 31 07:22:39 2007
@@ -29,7 +29,7 @@
  * Subclasses of this test can set up {@link #preElements} and {@link #postElements}
  * for extra elements not defined in the protocol session file.
  */
-public class SimpleFileProtocolTest
+public class SimpleScriptedTestProtocol
         extends AbstractProtocolTest
 {
     private FileProtocolSessionBuilder builder =
@@ -41,7 +41,7 @@
      * in the same location as this test class.
      * @param fileName The name of the file to read protocol elements from.
      */
-    public SimpleFileProtocolTest( String fileName, HostSystem hostSystem  )
+    public SimpleScriptedTestProtocol( String fileName, HostSystem hostSystem  )
     {
         super( fileName, hostSystem );
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r561339 - /james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On 7/31/07, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Just a hint: JUnit does not run test classes which are declared
> abstract. This saves me the headache of coming up with new class names. ;-)

thanks for the tip

i renamed that class at the time when i when it was concrete

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r561339 - /james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/

Posted by Bernd Fondermann <bf...@brainlounge.de>.
Just a hint: JUnit does not run test classes which are declared 
abstract. This saves me the headache of coming up with new class names. ;-)

   Bernd

rdonkin@apache.org wrote:
> Author: rdonkin
> Date: Tue Jul 31 07:22:39 2007
> New Revision: 561339
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=561339
> Log:
> Stop superclass being run as a test.
> 
> Added:
>     james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java
>       - copied, changed from r561318, james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java
> Removed:
>     james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java
> Modified:
>     james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java
>     james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java
>     james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java
> 
> Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java
> URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java?view=diff&rev=561339&r1=561338&r2=561339
> ==============================================================================
> --- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java (original)
> +++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/AbstractProtocolTest.java Tue Jul 31 07:22:39 2007
> @@ -30,7 +30,7 @@
>   * cases.  It provides basic functionality for running a protocol session
>   * as a JUnit test, and failing if exceptions are thrown.
>   * To create a test which reads the entire protocol session from a single
> - * protocol definition file, use the {@link SimpleFileProtocolTest}.
> + * protocol definition file, use the {@link SimpleScriptedTestProtocol}.
>   *
>   * @author Darrell DeBoer
>   * @author Andrew C. Oliver
> 
> Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java
> URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java?view=diff&rev=561339&r1=561338&r2=561339
> ==============================================================================
> --- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java (original)
> +++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestForAuthenticatedState.java Tue Jul 31 07:22:39 2007
> @@ -52,7 +52,7 @@
>   * </p>
>   */
>  public class BaseTestForAuthenticatedState
> -        extends SimpleFileProtocolTest implements ImapTestConstants
> +        extends SimpleScriptedTestProtocol implements ImapTestConstants
>  {
>      public BaseTestForAuthenticatedState( String name, HostSystem hostSystem)
>      {
> 
> Modified: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java
> URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java?view=diff&rev=561339&r1=561338&r2=561339
> ==============================================================================
> --- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java (original)
> +++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/BaseTestNonAuthenticatedState.java Tue Jul 31 07:22:39 2007
> @@ -37,7 +37,7 @@
>   * </ul>
>   */
>  public class BaseTestNonAuthenticatedState
> -        extends SimpleFileProtocolTest
> +        extends SimpleScriptedTestProtocol
>  {
>      public BaseTestNonAuthenticatedState( String name, HostSystem system )
>      {
> 
> Copied: james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java (from r561318, james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java)
> URL: http://svn.apache.org/viewvc/james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java?view=diff&rev=561339&p1=james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java&r1=561318&p2=james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java&r2=561339
> ==============================================================================
> --- james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleFileProtocolTest.java (original)
> +++ james/server/trunk/experimental-seda-imap-function/src/test/java/org/apache/james/test/functional/imap/SimpleScriptedTestProtocol.java Tue Jul 31 07:22:39 2007
> @@ -29,7 +29,7 @@
>   * Subclasses of this test can set up {@link #preElements} and {@link #postElements}
>   * for extra elements not defined in the protocol session file.
>   */
> -public class SimpleFileProtocolTest
> +public class SimpleScriptedTestProtocol
>          extends AbstractProtocolTest
>  {
>      private FileProtocolSessionBuilder builder =
> @@ -41,7 +41,7 @@
>       * in the same location as this test class.
>       * @param fileName The name of the file to read protocol elements from.
>       */
> -    public SimpleFileProtocolTest( String fileName, HostSystem hostSystem  )
> +    public SimpleScriptedTestProtocol( String fileName, HostSystem hostSystem  )
>      {
>          super( fileName, hostSystem );
>      }
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org