Re: [PATCH] Use neon's system proxy detection if not explicitly specified

[Daniel Shahaf <d....@daniel.shahaf.name>]

Dominique Leuenberger wrote on Mon, Sep 27, 2010 at 14:48:20 +0200:
> On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote:
> 
> > Better, but it'll still go wrong with Neon 0.40 or 1.00.  I guess it
> > needs to be something like:
> > 
> > if test -n ["`echo "$NEON_VERSION" | $EGREP
> >     '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then
> > 
> > ?  That should match 0.29-0.99 and 1.0 or later.  I'm assuming there
> > won't ever be a 0.100 release.
> > 
> 
> Right; the up to 0.39 check is a lazy copy paste from all the other
> check in neon.m4 :)
> 
> The check which exists already for 0.28 is like this:
>       if test -n ["`echo "$NEON_VERSION" | $EGREP '^0\.(2[8-9]|
> 3[0-9])\.'`"] ; then
>         AC_DEFINE_UNQUOTED([SVN_NEON_0_28], [1],
>                            [Define to 1 if you have Neon 0.28 or
> later.])
>       fi
> 
> 
> For me either way is fine: I can update the patch to also detect newer
> versions as suggest by you. Which in turn will still break all the other
> detections of SVN_NEON_0_28 and older. Or we keep them 'in sync'
> together and fix them all together at a later stage.

The latter please; when Neon 0.39 comes around we'll fix all checks at
the same time.

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

[Gavin Beau Baumanis <ga...@thespidernet.com>]

Ping. This patch has received no further comments.


Gavin "Beau" Baumanis


On 29/09/2010, at 8:48 PM, Dominique Leuenberger wrote:

> On Wed, 2010-09-29 at 12:42 +0200, Daniel Shahaf wrote:
>>> 
>>> For me either way is fine: I can update the patch to also detect newer
>>> versions as suggest by you. Which in turn will still break all the other
>>> detections of SVN_NEON_0_28 and older. Or we keep them 'in sync'
>>> together and fix them all together at a later stage.
>> 
>> The latter please; when Neon 0.39 comes around we'll fix all checks at
>> the same time.
> 
> In this case I would consider my patch complete, as this is already what
> has been submitted.
> 
> Thanks for your confirmation; Is there any further action to be taken by
> myself for this to happen?
> 
> Dominique
> 
> 

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

[Dominique Leuenberger <do...@leuenberger.net>]

On Wed, 2010-09-29 at 12:42 +0200, Daniel Shahaf wrote:
> > 
> > For me either way is fine: I can update the patch to also detect newer
> > versions as suggest by you. Which in turn will still break all the other
> > detections of SVN_NEON_0_28 and older. Or we keep them 'in sync'
> > together and fix them all together at a later stage.
> 
> The latter please; when Neon 0.39 comes around we'll fix all checks at
> the same time.

In this case I would consider my patch complete, as this is already what
has been submitted.

Thanks for your confirmation; Is there any further action to be taken by
myself for this to happen?

Dominique