You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2012/09/04 22:52:08 UTC
[jira] [Created] (BOOKKEEPER-394) CompositeException message is not
useful
Stu Hood created BOOKKEEPER-394:
-----------------------------------
Summary: CompositeException message is not useful
Key: BOOKKEEPER-394
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
Project: Bookkeeper
Issue Type: Improvement
Reporter: Stu Hood
Priority: Minor
Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-394) CompositeException message is not
useful
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-394:
--------------------------------
Attachment: 394.diff
> CompositeException message is not useful
> ----------------------------------------
>
> Key: BOOKKEEPER-394
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Attachments: 394.diff
>
>
> Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
> Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-394) CompositeException message is
not useful
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449708#comment-13449708 ]
Flavio Junqueira commented on BOOKKEEPER-394:
---------------------------------------------
Thanks, Stu. It looks good to me, +1.
> CompositeException message is not useful
> ----------------------------------------
>
> Key: BOOKKEEPER-394
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Attachments: 394.diff
>
>
> Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
> Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-394) CompositeException message is
not useful
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450300#comment-13450300 ]
Hudson commented on BOOKKEEPER-394:
-----------------------------------
Integrated in bookkeeper-trunk #694 (See [https://builds.apache.org/job/bookkeeper-trunk/694/])
BOOKKEEPER-394: CompositeException message is not useful (Stu Hood via sijie) (Revision 1381848)
Result = SUCCESS
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/exceptions/PubSubException.java
> CompositeException message is not useful
> ----------------------------------------
>
> Key: BOOKKEEPER-394
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: 394.diff
>
>
> Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
> Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-394) CompositeException message is
not useful
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira reassigned BOOKKEEPER-394:
-------------------------------------------
Assignee: Stu Hood
> CompositeException message is not useful
> ----------------------------------------
>
> Key: BOOKKEEPER-394
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Attachments: 394.diff
>
>
> Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
> Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-394) CompositeException message is
not useful
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450293#comment-13450293 ]
Sijie Guo commented on BOOKKEEPER-394:
--------------------------------------
BTW, @Stu, when you generate the patch, could you use '--no-prefix' option to remove the prefix? it might be easier for applying the patch. :)
> CompositeException message is not useful
> ----------------------------------------
>
> Key: BOOKKEEPER-394
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-394
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: 394.diff
>
>
> Exceptions logged via slf4j don't actually have their toString method called, so the current behaviour of overriding toString for CompositeException is rarely/never triggered in client code.
> Composing a better `message` field for CompositeException would make it loggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira