You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2021/10/23 03:04:16 UTC
[datasketches-java] branch tupleUpdatableSerDeDeprecation created
(now 19e5299)
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a change to branch tupleUpdatableSerDeDeprecation
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git.
at 19e5299 Merge branch 'FixMinorCheckstyleIssues' into tupleUpdatableDeprecation
This branch includes the following new commits:
new 7926128 Deprecate all occurrences of serializing or deserializing UpdateSketch or its derivatives.
new 35bdf64 Cleanup Imports mostly
new 19e5299 Merge branch 'FixMinorCheckstyleIssues' into tupleUpdatableDeprecation
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[datasketches-java] 03/03: Merge branch 'FixMinorCheckstyleIssues'
into tupleUpdatableDeprecation
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch tupleUpdatableSerDeDeprecation
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 19e52996164baf40c954b362e8479be5040c854e
Merge: 7926128 35bdf64
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Fri Oct 22 19:54:48 2021 -0700
Merge branch 'FixMinorCheckstyleIssues' into tupleUpdatableDeprecation
.../java/org/apache/datasketches/tuple/CompactSketch.java | 14 ++++++++------
.../java/org/apache/datasketches/tuple/IntegerSummary.java | 2 --
.../datasketches/tuple/IntegerSummaryDeserializer.java | 2 --
.../apache/datasketches/tuple/IntegerSummaryFactory.java | 3 ---
.../org/apache/datasketches/tuple/SerialVersion3Test.java | 6 ++----
5 files changed, 10 insertions(+), 17 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[datasketches-java] 01/03: Deprecate all occurrences of serializing
or deserializing UpdateSketch or its derivatives.
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch tupleUpdatableSerDeDeprecation
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 7926128138f9521982653e69ba8b1f577f15dac1
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Fri Oct 22 18:31:14 2021 -0700
Deprecate all occurrences of serializing or deserializing UpdateSketch
or its derivatives.
---
src/main/java/org/apache/datasketches/fdt/FdtSketch.java | 4 ++++
.../org/apache/datasketches/tuple/QuickSelectSketch.java | 10 ++++++++++
src/main/java/org/apache/datasketches/tuple/Sketch.java | 6 +++++-
.../java/org/apache/datasketches/tuple/Sketches.java | 16 ++++++++++++----
.../org/apache/datasketches/tuple/UpdatableSketch.java | 4 ++++
.../apache/datasketches/tuple/adouble/DoubleSketch.java | 4 ++++
.../datasketches/tuple/aninteger/IntegerSketch.java | 4 ++++
.../datasketches/tuple/strings/ArrayOfStringsSketch.java | 4 ++++
.../java/org/apache/datasketches/fdt/FdtSketchTest.java | 6 +++---
.../tuple/CompactSketchWithDoubleSummaryTest.java | 1 +
.../apache/datasketches/tuple/adouble/AdoubleTest.java | 4 ++++
.../datasketches/tuple/aninteger/IntegerSketchTest.java | 1 +
.../tuple/strings/ArrayOfStringsSketchTest.java | 1 +
13 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/apache/datasketches/fdt/FdtSketch.java b/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
index d04dacd..6cf4b34 100644
--- a/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
+++ b/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
@@ -61,7 +61,11 @@ public class FdtSketch extends ArrayOfStringsSketch {
/**
* Used by deserialization.
* @param mem the image of a FdtSketch
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
+ @Deprecated
FdtSketch(final Memory mem) {
super(mem);
}
diff --git a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java
index 9295456..ed19354 100644
--- a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java
@@ -140,6 +140,9 @@ class QuickSelectSketch<S extends Summary> extends Sketch<S> {
* @param mem Memory object with serialized QukckSelectSketch
* @param deserializer the SummaryDeserializer
* @param summaryFactory the SummaryFactory
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
@Deprecated
QuickSelectSketch(
@@ -314,6 +317,13 @@ class QuickSelectSketch<S extends Summary> extends Sketch<S> {
// Adr:
// || 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 |
// 0 || RF | lgArr | lgNom | Flags | SkType | FamID | SerVer | Preamble_Longs |
+ /**
+ * This serializes an UpdatableSketch (QuickSelectSketch).
+ * @return serialized representation of an UpdatableSketch (QuickSelectSketch).
+ * @deprecated As of 3.0.0, serializing an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Serializing a CompactSketch is not deprecated.
+ */
@Deprecated
@SuppressWarnings("null")
@Override
diff --git a/src/main/java/org/apache/datasketches/tuple/Sketch.java b/src/main/java/org/apache/datasketches/tuple/Sketch.java
index 1ca7f9e..9dfb14b 100644
--- a/src/main/java/org/apache/datasketches/tuple/Sketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/Sketch.java
@@ -161,7 +161,11 @@ public abstract class Sketch<S extends Summary> {
}
/**
- * This is to serialize an instance to a byte array.
+ * This is to serialize a sketch instance to a byte array.
+ *
+ * <p>As of 3.0.0, serializing an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Serializing a CompactSketch is not deprecated.</p>
* @return serialized representation of the sketch
*/
public abstract byte[] toByteArray();
diff --git a/src/main/java/org/apache/datasketches/tuple/Sketches.java b/src/main/java/org/apache/datasketches/tuple/Sketches.java
index 6227883..0630daa 100644
--- a/src/main/java/org/apache/datasketches/tuple/Sketches.java
+++ b/src/main/java/org/apache/datasketches/tuple/Sketches.java
@@ -35,12 +35,17 @@ public final class Sketches {
}
/**
- * Instantiate Sketch from a given Memory
+ * Instantiate a Sketch from a given Memory.
+ *
+ * <p>As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.</p>
* @param <S> Type of Summary
* @param mem Memory object representing a Sketch
* @param deserializer instance of SummaryDeserializer
* @return Sketch created from its Memory representation
*/
+ @SuppressWarnings("deprecation")
public static <S extends Summary> Sketch<S> heapifySketch(final Memory mem,
final SummaryDeserializer<S> deserializer) {
final SerializerDeserializer.SketchType sketchType = SerializerDeserializer.getSketchType(mem);
@@ -58,10 +63,13 @@ public final class Sketches {
* @param deserializer instance of SummaryDeserializer
* @param summaryFactory instance of SummaryFactory
* @return Sketch created from its Memory representation
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
- public static <U, S extends
- UpdatableSummary<U>> UpdatableSketch<U, S> heapifyUpdatableSketch(final Memory mem,
- final SummaryDeserializer<S> deserializer, final SummaryFactory<S> summaryFactory) {
+ @Deprecated
+ public static <U, S extends UpdatableSummary<U>> UpdatableSketch<U, S> heapifyUpdatableSketch(
+ final Memory mem, final SummaryDeserializer<S> deserializer, final SummaryFactory<S> summaryFactory) {
return new UpdatableSketch<U, S>(mem, deserializer, summaryFactory);
}
diff --git a/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java b/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
index b6aa87f..9df6218 100644
--- a/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
@@ -65,7 +65,11 @@ public class UpdatableSketch<U, S extends UpdatableSummary<U>> extends QuickSele
* @param srcMem Memory object with data of a serialized UpdatableSketch
* @param deserializer instance of SummaryDeserializer
* @param summaryFactory instance of SummaryFactory
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
+ @Deprecated
public UpdatableSketch(final Memory srcMem, final SummaryDeserializer<S> deserializer,
final SummaryFactory<S> summaryFactory) {
super(srcMem, deserializer, summaryFactory);
diff --git a/src/main/java/org/apache/datasketches/tuple/adouble/DoubleSketch.java b/src/main/java/org/apache/datasketches/tuple/adouble/DoubleSketch.java
index 92e2cbe..9fd9a3c 100644
--- a/src/main/java/org/apache/datasketches/tuple/adouble/DoubleSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/adouble/DoubleSketch.java
@@ -62,7 +62,11 @@ public class DoubleSketch extends UpdatableSketch<Double, DoubleSummary> {
* usually with data.
* @param mem the given Memory
* @param mode The DoubleSummary mode to be used
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
+ @Deprecated
public DoubleSketch(final Memory mem, final DoubleSummary.Mode mode) {
super(mem, new DoubleSummaryDeserializer(), new DoubleSummaryFactory(mode));
}
diff --git a/src/main/java/org/apache/datasketches/tuple/aninteger/IntegerSketch.java b/src/main/java/org/apache/datasketches/tuple/aninteger/IntegerSketch.java
index 03ca7d0..de4b68e 100644
--- a/src/main/java/org/apache/datasketches/tuple/aninteger/IntegerSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/aninteger/IntegerSketch.java
@@ -62,7 +62,11 @@ public class IntegerSketch extends UpdatableSketch<Integer, IntegerSummary> {
* usually with data.
* @param mem the given Memory
* @param mode The IntegerSummary mode to be used
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
+ @Deprecated
public IntegerSketch(final Memory mem, final IntegerSummary.Mode mode) {
super(mem, new IntegerSummaryDeserializer(), new IntegerSummaryFactory(mode));
}
diff --git a/src/main/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketch.java b/src/main/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketch.java
index 3bfcbaf..5d73319 100644
--- a/src/main/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketch.java
@@ -64,7 +64,11 @@ public class ArrayOfStringsSketch extends UpdatableSketch<String[], ArrayOfStrin
* Constructs this sketch from a Memory image, which must be from an ArrayOfStringsSketch, and
* usually with data.
* @param mem the given Memory
+ * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
+ * This capability will be removed in a future release.
+ * Heapifying a CompactSketch is not deprecated.
*/
+ @Deprecated
public ArrayOfStringsSketch(final Memory mem) {
super(mem, new ArrayOfStringsSummaryDeserializer(), new ArrayOfStringsSummaryFactory());
}
diff --git a/src/test/java/org/apache/datasketches/fdt/FdtSketchTest.java b/src/test/java/org/apache/datasketches/fdt/FdtSketchTest.java
index afd7e69..dc99e4a 100644
--- a/src/test/java/org/apache/datasketches/fdt/FdtSketchTest.java
+++ b/src/test/java/org/apache/datasketches/fdt/FdtSketchTest.java
@@ -25,12 +25,11 @@ import static org.testng.Assert.fail;
import java.util.List;
-import org.testng.annotations.Test;
-
-import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.SketchesArgumentException;
+import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.tuple.SketchIterator;
import org.apache.datasketches.tuple.strings.ArrayOfStringsSummary;
+import org.testng.annotations.Test;
/**
* @author Lee Rhodes
@@ -40,6 +39,7 @@ public class FdtSketchTest {
private static final String LS = System.getProperty("line.separator");
private static final char sep = '|'; //string separator
+ @SuppressWarnings("deprecation")
@Test
public void checkFdtSketch() {
final int lgK = 14;
diff --git a/src/test/java/org/apache/datasketches/tuple/CompactSketchWithDoubleSummaryTest.java b/src/test/java/org/apache/datasketches/tuple/CompactSketchWithDoubleSummaryTest.java
index b068ea8..710e751 100644
--- a/src/test/java/org/apache/datasketches/tuple/CompactSketchWithDoubleSummaryTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/CompactSketchWithDoubleSummaryTest.java
@@ -175,6 +175,7 @@ public class CompactSketchWithDoubleSummaryTest {
Assert.assertEquals(count, 4096);
}
+ @SuppressWarnings("deprecation")
@Test(expectedExceptions = SketchesArgumentException.class)
public void deserializeWrongType() {
UpdatableSketch<Double, DoubleSummary> us =
diff --git a/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java b/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
index 8f29284..87396d9 100644
--- a/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
@@ -63,6 +63,7 @@ public class AdoubleTest {
assertEquals(sk.getLgK(), 4);
}
+ @SuppressWarnings("deprecation")
@Test
public void serDeTest() {
final int lgK = 12;
@@ -319,6 +320,7 @@ public class AdoubleTest {
}
}
+ @SuppressWarnings("deprecation")
@Test
public void serializeDeserializeExact() throws Exception {
final UpdatableSketch<Double, DoubleSummary> sketch1 =
@@ -343,6 +345,7 @@ public class AdoubleTest {
Assert.assertEquals(sketch2.getEstimate(), 2.0);
}
+ @SuppressWarnings("deprecation")
@Test
public void serializeDeserializeEstimationNoResizing() throws Exception {
final UpdatableSketch<Double, DoubleSummary> sketch1 =
@@ -373,6 +376,7 @@ public class AdoubleTest {
Assert.assertEquals(count, 4096);
}
+ @SuppressWarnings("deprecation")
@Test
public void serializeDeserializeSampling() throws Exception {
final int sketchSize = 16384;
diff --git a/src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java b/src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java
index 74bb984..4819fbe 100644
--- a/src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java
@@ -33,6 +33,7 @@ import org.testng.annotations.Test;
@SuppressWarnings("javadoc")
public class IntegerSketchTest {
+ @SuppressWarnings("deprecation")
@Test
public void serDeTest() {
final int lgK = 12;
diff --git a/src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java b/src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java
index 9bc1e45..031417f 100644
--- a/src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java
@@ -37,6 +37,7 @@ import org.testng.annotations.Test;
public class ArrayOfStringsSketchTest {
private static final String LS = System.getProperty("line.separator");
+ @SuppressWarnings("deprecation")
@Test
public void checkSketch() {
ArrayOfStringsSketch sketch1 = new ArrayOfStringsSketch();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[datasketches-java] 02/03: Cleanup Imports mostly
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch tupleUpdatableSerDeDeprecation
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 35bdf643e6c077b65077cafaed777bc2d1a63f95
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Fri Oct 22 18:47:09 2021 -0700
Cleanup Imports mostly
---
.../java/org/apache/datasketches/tuple/CompactSketch.java | 14 ++++++++------
.../java/org/apache/datasketches/tuple/IntegerSummary.java | 2 --
.../datasketches/tuple/IntegerSummaryDeserializer.java | 2 --
.../apache/datasketches/tuple/IntegerSummaryFactory.java | 3 ---
.../org/apache/datasketches/tuple/SerialVersion3Test.java | 6 ++----
5 files changed, 10 insertions(+), 17 deletions(-)
diff --git a/src/main/java/org/apache/datasketches/tuple/CompactSketch.java b/src/main/java/org/apache/datasketches/tuple/CompactSketch.java
index a96b15a..43406e7 100644
--- a/src/main/java/org/apache/datasketches/tuple/CompactSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/CompactSketch.java
@@ -48,6 +48,7 @@ public class CompactSketch<S extends Summary> extends Sketch<S> {
private S[] summaryArr_;
private enum FlagsLegacy { IS_BIG_ENDIAN, IS_EMPTY, HAS_ENTRIES, IS_THETA_INCLUDED }
+
private enum Flags { IS_BIG_ENDIAN, IS_READ_ONLY, IS_EMPTY, IS_COMPACT, IS_ORDERED }
/**
@@ -146,7 +147,8 @@ public class CompactSketch<S extends Summary> extends Sketch<S> {
}
@SuppressWarnings({"unchecked"})
- private int readSummary(final Memory mem, final int offset, final int i, final int count, final SummaryDeserializer<S> deserializer) {
+ private int readSummary(final Memory mem, final int offset, final int i, final int count,
+ final SummaryDeserializer<S> deserializer) {
final Memory memRegion = mem.region(offset, mem.getCapacity() - offset);
final DeserializeResult<S> result = deserializer.heapifySummary(memRegion);
final S summary = result.getObject();
@@ -189,11 +191,11 @@ public class CompactSketch<S extends Summary> extends Sketch<S> {
@SuppressWarnings("null")
@Override
public byte[] toByteArray() {
- final int count = getRetainedEntries();
+ final int count = getRetainedEntries();
final boolean isSingleItem = count == 1 && !isEstimationMode();
final int preambleLongs = isEmpty() || isSingleItem ? 1 : isEstimationMode() ? 3 : 2;
- int summariesSizeBytes = 0;
+ int summariesSizeBytes = 0;
byte[][] summariesBytes = null;
if (count > 0) {
summariesBytes = new byte[count][];
@@ -203,7 +205,7 @@ public class CompactSketch<S extends Summary> extends Sketch<S> {
}
}
- int sizeBytes = Long.BYTES * preambleLongs + Long.BYTES * count + summariesSizeBytes;
+ final int sizeBytes = Long.BYTES * preambleLongs + Long.BYTES * count + summariesSizeBytes;
final byte[] bytes = new byte[sizeBytes];
int offset = 0;
bytes[offset++] = (byte) preambleLongs;
@@ -224,8 +226,8 @@ public class CompactSketch<S extends Summary> extends Sketch<S> {
offset += Integer.BYTES;
offset += 4; // unused
if (isEstimationMode()) {
- ByteArrayUtil.putLongLE(bytes, offset, thetaLong_);
- offset += Long.BYTES;
+ ByteArrayUtil.putLongLE(bytes, offset, thetaLong_);
+ offset += Long.BYTES;
}
}
}
diff --git a/src/test/java/org/apache/datasketches/tuple/IntegerSummary.java b/src/test/java/org/apache/datasketches/tuple/IntegerSummary.java
index 3d27c2b..ab24672 100644
--- a/src/test/java/org/apache/datasketches/tuple/IntegerSummary.java
+++ b/src/test/java/org/apache/datasketches/tuple/IntegerSummary.java
@@ -21,8 +21,6 @@ package org.apache.datasketches.tuple;
import org.apache.datasketches.ByteArrayUtil;
import org.apache.datasketches.memory.Memory;
-import org.apache.datasketches.tuple.DeserializeResult;
-import org.apache.datasketches.tuple.UpdatableSummary;
/**
* Summary for generic tuple sketches of type Integer.
diff --git a/src/test/java/org/apache/datasketches/tuple/IntegerSummaryDeserializer.java b/src/test/java/org/apache/datasketches/tuple/IntegerSummaryDeserializer.java
index a7caa85..33c0e34 100644
--- a/src/test/java/org/apache/datasketches/tuple/IntegerSummaryDeserializer.java
+++ b/src/test/java/org/apache/datasketches/tuple/IntegerSummaryDeserializer.java
@@ -20,8 +20,6 @@
package org.apache.datasketches.tuple;
import org.apache.datasketches.memory.Memory;
-import org.apache.datasketches.tuple.DeserializeResult;
-import org.apache.datasketches.tuple.SummaryDeserializer;
public class IntegerSummaryDeserializer implements SummaryDeserializer<IntegerSummary> {
diff --git a/src/test/java/org/apache/datasketches/tuple/IntegerSummaryFactory.java b/src/test/java/org/apache/datasketches/tuple/IntegerSummaryFactory.java
index 30313a3..cc21fff 100644
--- a/src/test/java/org/apache/datasketches/tuple/IntegerSummaryFactory.java
+++ b/src/test/java/org/apache/datasketches/tuple/IntegerSummaryFactory.java
@@ -19,9 +19,6 @@
package org.apache.datasketches.tuple;
-import org.apache.datasketches.tuple.IntegerSummary;
-import org.apache.datasketches.tuple.SummaryFactory;
-
/**
* Factory for IntegerSummary.
*/
diff --git a/src/test/java/org/apache/datasketches/tuple/SerialVersion3Test.java b/src/test/java/org/apache/datasketches/tuple/SerialVersion3Test.java
index 9808308..57f5b5c 100644
--- a/src/test/java/org/apache/datasketches/tuple/SerialVersion3Test.java
+++ b/src/test/java/org/apache/datasketches/tuple/SerialVersion3Test.java
@@ -19,13 +19,11 @@
package org.apache.datasketches.tuple;
-import org.testng.Assert;
-import org.testng.annotations.Test;
-
import static org.apache.datasketches.Util.getResourceBytes;
import org.apache.datasketches.memory.Memory;
-import org.apache.datasketches.tuple.IntegerSummary;
+import org.testng.Assert;
+import org.testng.annotations.Test;
@SuppressWarnings("javadoc")
public class SerialVersion3Test {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org