[GitHub] [helix] kaisun2000 commented on a change in pull request #1451: testUpdateConfigFields failure

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1451:
URL: https://github.com/apache/helix/pull/1451#discussion_r503729266



##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -243,6 +243,7 @@ public void testAddConfigFields() throws IOException {
     oldConfig.getRecord().update(configDelta.getRecord());
     Assert.assertEquals(newConfig, oldConfig,
         "cluster config from response: " + newConfig + " vs cluster config actually: " + oldConfig);
+    System.out.println("new config:" + newConfig.toString());

Review comment:
       This is to figure out what goes wrong, as this test:
   
   1/ does not fail in my local run
   
   2/ fails some times in git hub run.
   
   3/ start to fail recently.
   
   Now the root cause is clear. Basically, the INSTANCE_CAPACITY_KEYS list field can appear in the test and fail the test as the test does not expect this field to "magically" appear, depends on timing. 
   
   It turned out to be the case that Waged Rebalancer would add this field to the cluster config when they finished the first global run.  Depending on the global run timing, the can fail. 
   
   See the detailed analysis in the following issue: https://github.com/apache/helix/issues/1336




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org