You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/09/04 18:01:36 UTC
Review Request 62070: Added protobufs to CMake project to facilitate
indexing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62070/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
Repository: mesos
Description
-------
Some IDEs and indexing tools build the project structure from CMake
target definitions. In this case files that are not essential for
building the target and are omitted from the target declaration,
do not appear in the project either and hence are not searchable
inside the IDE or indexing tool.
Diffs
-----
src/CMakeLists.txt 0562b2bf87fb6e2b65a2a512e694e89ee431738b
src/cmake/MesosProtobuf.cmake 533455e3b650dfb9e2b8c73e83c60ecc99613985
Diff: https://reviews.apache.org/r/62070/diff/1/
Testing
-------
See https://reviews.apache.org/r/62071/.
Thanks,
Alexander Rukletsov
Re: Review Request 62070: Added protobufs to CMake project to
facilitate indexing.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62070/#review184723
-----------------------------------------------------------
src/CMakeLists.txt
Line 594 (original), 597 (patched)
<https://reviews.apache.org/r/62070/#comment260913>
Is there an alternative approach we can take? Following this logic, we'd also add header files, and explicitly don't want to add that superfluous information to the CMake build.
Maybe reintroduce [`source_group()`](https://cmake.org/cmake/help/latest/command/source_group.html) (but get it working without a custom macro around it)?
- Andrew Schwartzmeyer
On Sept. 4, 2017, 11:01 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62070/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 11:01 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some IDEs and indexing tools build the project structure from CMake
> target definitions. In this case files that are not essential for
> building the target and are omitted from the target declaration,
> do not appear in the project either and hence are not searchable
> inside the IDE or indexing tool.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 0562b2bf87fb6e2b65a2a512e694e89ee431738b
> src/cmake/MesosProtobuf.cmake 533455e3b650dfb9e2b8c73e83c60ecc99613985
>
>
> Diff: https://reviews.apache.org/r/62070/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/62071/.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>