You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Charles Yates (JIRA)" <ji...@apache.org> on 2010/01/29 19:56:34 UTC
[jira] Created: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
XIncludeTransformer sends extra startDocument and endDocument events
--------------------------------------------------------------------
Key: COCOON3-51
URL: https://issues.apache.org/jira/browse/COCOON3-51
Project: Cocoon 3
Issue Type: Bug
Components: cocoon-sax
Affects Versions: 3.0.0-alpha-3
Reporter: Charles Yates
Assignee: Cocoon Developers Team
Attachments: patch.txt
The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806746#action_12806746 ]
Simone Tripodi commented on COCOON3-51:
---------------------------------------
very very appreciated Charles, thanks, test is meaningful and way of submitting patches is now much better, but please keep in mindfor the future patches you'll submit, when adding new resources, like the XML test, please add the Apache License header.
I would avoid adding an external dependency in the XIncludeTransformer that's a dependencies-less class. I'm sure there is a bug on the use of 'xIncludeElementLevel' class field, which scope is also avoiding the bug you noticed.
BTW, well done ;)
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Simone Tripodi
> Attachments: COCOON3-51.txt, patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi reassigned COCOON3-51:
-------------------------------------
Assignee: Simone Tripodi (was: Cocoon Developers Team)
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Simone Tripodi
> Attachments: patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806671#action_12806671 ]
Simone Tripodi commented on COCOON3-51:
---------------------------------------
Generally speaking, It would be nice also if you could provide testcases to show why the patch has to be applied.
Thanks in advance!!!
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Cocoon Developers Team
> Attachments: patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Charles Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831099#action_12831099 ]
Charles Yates commented on COCOON3-51:
--------------------------------------
Thank you Simone, I also concluded keeping track of the document level was the best solution.
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Simone Tripodi
> Fix For: 3.0.0-alpha-3
>
> Attachments: COCOON3-51.txt, patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806464#action_12806464 ]
Simone Tripodi commented on COCOON3-51:
---------------------------------------
Hi Charles,
very appreciated, when I implemented the XInclude i was sure it was aware from such problems but I'll apply the patch ASAP (maybe tomorrow)
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Cocoon Developers Team
> Attachments: patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806668#action_12806668 ]
Simone Tripodi commented on COCOON3-51:
---------------------------------------
Charles,
instead of declaring yet another variable (the documentLevel) can you help us understanding why with the xIncludeElementLevel doesn't work?
Yet another suggestion: when naming patches, can you please call patch files with meaningful names?
Thanks in advance, very appreciated!!!
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Cocoon Developers Team
> Attachments: patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Charles Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Yates updated COCOON3-51:
---------------------------------
Attachment: patch.txt
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Cocoon Developers Team
> Attachments: patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi closed COCOON3-51.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0-alpha-3
Patch applied successfully. I investigated a lot about it before applying it and I combined the two patches provided, there's no better way than using the 'documentLevel' variable - see first submitted patch - and tested with test provided in the second patch.
Thanks Charles :)
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Simone Tripodi
> Fix For: 3.0.0-alpha-3
>
> Attachments: COCOON3-51.txt, patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-51) XIncludeTransformer sends extra
startDocument and endDocument events
Posted by "Charles Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Yates updated COCOON3-51:
---------------------------------
Attachment: COCOON3-51.txt
Hi Simone,
Of course you are right I should include test cases. Also in this patch is a more elegant fix using org.apache.cocoon.xml.sax.EmbeddedSAXPipe to catch the extra document events.
> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
> Key: COCOON3-51
> URL: https://issues.apache.org/jira/browse/COCOON3-51
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-3
> Reporter: Charles Yates
> Assignee: Simone Tripodi
> Attachments: COCOON3-51.txt, patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent handlers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.