You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jihun Kang <yk...@gmail.com> on 2015/07/27 08:47:28 UTC

Review Request 36840: Changed comparison functions for floating-point numbers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36840/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3150
    https://issues.apache.org/jira/browse/MESOS-3150


Repository: mesos


Description
-------

Changed comparison functions for floating-point numbers


Diffs
-----

  src/tests/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 
  src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e 
  src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 

Diff: https://reviews.apache.org/r/36840/diff/


Testing
-------

Test has passed on MESOS 0.22.1.

[----------] Global test environment tear-down
[==========] 539 tests from 86 test cases ran. (353845 ms total)
[  PASSED  ] 539 tests.


Thanks,

Jihun Kang


Re: Review Request 36840: Changed comparison functions for floating-point numbers

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36840/#review93092
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On July 27, 2015, 6:47 a.m., Jihun Kang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36840/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 6:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3150
>     https://issues.apache.org/jira/browse/MESOS-3150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed comparison functions for floating-point numbers
> 
> 
> Diffs
> -----
> 
>   src/tests/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 
>   src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/36840/diff/
> 
> 
> Testing
> -------
> 
> Test has passed on MESOS 0.22.1.
> 
> [----------] Global test environment tear-down
> [==========] 539 tests from 86 test cases ran. (353845 ms total)
> [  PASSED  ] 539 tests.
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>