You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Xavier Léauté <xa...@confluent.io> on 2016/12/09 18:27:25 UTC
[VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Hi everyone,
I would like to start the vote for KIP-100 unless there are any more
comments.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+Relax+Type+constraints+in+Kafka+Streams+API
corresponding PR here https://github.com/apache/kafka/pull/2205
Thanks,
Xavier
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
This passes with 4 binding and 7 total +1 votes.
Xavier, I've marked the JIRA for 0.10.2.0, which I assume we'll be able to
make, and moved it as WIP into the adopted KIPs section.
-Ewen
On Mon, Dec 19, 2016 at 2:33 PM, Guozhang Wang <wa...@gmail.com> wrote:
> +1.
>
> On Sat, Dec 17, 2016 at 3:27 AM, Ismael Juma <is...@juma.me.uk> wrote:
>
> > Thanks Xavier. +1 (binding)
> >
> > Ismael
> >
> > On Fri, Dec 16, 2016 at 8:15 PM, Xavier Léauté <xa...@confluent.io>
> > wrote:
> >
> > > Ismael made a good point so I updated KIP-100 and expanded its scope to
> > > include covariant result types for functions applied to streams.
> > > I will update the discussion thread accordingly.
> > >
> > > On Tue, Dec 13, 2016 at 12:13 AM Ismael Juma <is...@juma.me.uk>
> wrote:
> > >
> > > > Hi Xavier,
> > > >
> > > > Thanks for the KIP. If Java had declaration site variance (proposed
> > for a
> > > > future Java version[1]), we'd mark function parameters as
> contravariant
> > > > (i.e. "super") and the result as covariant (i.e. "extends"). In the
> > > > meantime, we have to use the wildcards at use site as per your
> > proposal.
> > > > However, it seems that only the first case is covered by your
> proposal.
> > > > This is an improvement, but is there any reason not to do the latter
> as
> > > > well? It would be good to get it completely right this time.
> > > >
> > > > Ismael
> > > >
> > > > [1] http://openjdk.java.net/jeps/300
> > > >
> > > > On Fri, Dec 9, 2016 at 6:27 PM, Xavier Léauté <xa...@confluent.io>
> > > wrote:
> > > >
> > > > > Hi everyone,
> > > > >
> > > > > I would like to start the vote for KIP-100 unless there are any
> more
> > > > > comments.
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+
> > > > > Relax+Type+constraints+in+Kafka+Streams+API
> > > > >
> > > > > corresponding PR here https://github.com/apache/kafka/pull/2205
> > > > >
> > > > > Thanks,
> > > > > Xavier
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Guozhang Wang <wa...@gmail.com>.
+1.
On Sat, Dec 17, 2016 at 3:27 AM, Ismael Juma <is...@juma.me.uk> wrote:
> Thanks Xavier. +1 (binding)
>
> Ismael
>
> On Fri, Dec 16, 2016 at 8:15 PM, Xavier Léauté <xa...@confluent.io>
> wrote:
>
> > Ismael made a good point so I updated KIP-100 and expanded its scope to
> > include covariant result types for functions applied to streams.
> > I will update the discussion thread accordingly.
> >
> > On Tue, Dec 13, 2016 at 12:13 AM Ismael Juma <is...@juma.me.uk> wrote:
> >
> > > Hi Xavier,
> > >
> > > Thanks for the KIP. If Java had declaration site variance (proposed
> for a
> > > future Java version[1]), we'd mark function parameters as contravariant
> > > (i.e. "super") and the result as covariant (i.e. "extends"). In the
> > > meantime, we have to use the wildcards at use site as per your
> proposal.
> > > However, it seems that only the first case is covered by your proposal.
> > > This is an improvement, but is there any reason not to do the latter as
> > > well? It would be good to get it completely right this time.
> > >
> > > Ismael
> > >
> > > [1] http://openjdk.java.net/jeps/300
> > >
> > > On Fri, Dec 9, 2016 at 6:27 PM, Xavier Léauté <xa...@confluent.io>
> > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > I would like to start the vote for KIP-100 unless there are any more
> > > > comments.
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+
> > > > Relax+Type+constraints+in+Kafka+Streams+API
> > > >
> > > > corresponding PR here https://github.com/apache/kafka/pull/2205
> > > >
> > > > Thanks,
> > > > Xavier
> > > >
> > >
> >
>
--
-- Guozhang
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Ismael Juma <is...@juma.me.uk>.
Thanks Xavier. +1 (binding)
Ismael
On Fri, Dec 16, 2016 at 8:15 PM, Xavier Léauté <xa...@confluent.io> wrote:
> Ismael made a good point so I updated KIP-100 and expanded its scope to
> include covariant result types for functions applied to streams.
> I will update the discussion thread accordingly.
>
> On Tue, Dec 13, 2016 at 12:13 AM Ismael Juma <is...@juma.me.uk> wrote:
>
> > Hi Xavier,
> >
> > Thanks for the KIP. If Java had declaration site variance (proposed for a
> > future Java version[1]), we'd mark function parameters as contravariant
> > (i.e. "super") and the result as covariant (i.e. "extends"). In the
> > meantime, we have to use the wildcards at use site as per your proposal.
> > However, it seems that only the first case is covered by your proposal.
> > This is an improvement, but is there any reason not to do the latter as
> > well? It would be good to get it completely right this time.
> >
> > Ismael
> >
> > [1] http://openjdk.java.net/jeps/300
> >
> > On Fri, Dec 9, 2016 at 6:27 PM, Xavier Léauté <xa...@confluent.io>
> wrote:
> >
> > > Hi everyone,
> > >
> > > I would like to start the vote for KIP-100 unless there are any more
> > > comments.
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+
> > > Relax+Type+constraints+in+Kafka+Streams+API
> > >
> > > corresponding PR here https://github.com/apache/kafka/pull/2205
> > >
> > > Thanks,
> > > Xavier
> > >
> >
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Xavier Léauté <xa...@confluent.io>.
Ismael made a good point so I updated KIP-100 and expanded its scope to
include covariant result types for functions applied to streams.
I will update the discussion thread accordingly.
On Tue, Dec 13, 2016 at 12:13 AM Ismael Juma <is...@juma.me.uk> wrote:
> Hi Xavier,
>
> Thanks for the KIP. If Java had declaration site variance (proposed for a
> future Java version[1]), we'd mark function parameters as contravariant
> (i.e. "super") and the result as covariant (i.e. "extends"). In the
> meantime, we have to use the wildcards at use site as per your proposal.
> However, it seems that only the first case is covered by your proposal.
> This is an improvement, but is there any reason not to do the latter as
> well? It would be good to get it completely right this time.
>
> Ismael
>
> [1] http://openjdk.java.net/jeps/300
>
> On Fri, Dec 9, 2016 at 6:27 PM, Xavier Léauté <xa...@confluent.io> wrote:
>
> > Hi everyone,
> >
> > I would like to start the vote for KIP-100 unless there are any more
> > comments.
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+
> > Relax+Type+constraints+in+Kafka+Streams+API
> >
> > corresponding PR here https://github.com/apache/kafka/pull/2205
> >
> > Thanks,
> > Xavier
> >
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Ismael Juma <is...@juma.me.uk>.
Hi Xavier,
Thanks for the KIP. If Java had declaration site variance (proposed for a
future Java version[1]), we'd mark function parameters as contravariant
(i.e. "super") and the result as covariant (i.e. "extends"). In the
meantime, we have to use the wildcards at use site as per your proposal.
However, it seems that only the first case is covered by your proposal.
This is an improvement, but is there any reason not to do the latter as
well? It would be good to get it completely right this time.
Ismael
[1] http://openjdk.java.net/jeps/300
On Fri, Dec 9, 2016 at 6:27 PM, Xavier Léauté <xa...@confluent.io> wrote:
> Hi everyone,
>
> I would like to start the vote for KIP-100 unless there are any more
> comments.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+
> Relax+Type+constraints+in+Kafka+Streams+API
>
> corresponding PR here https://github.com/apache/kafka/pull/2205
>
> Thanks,
> Xavier
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Neha Narkhede <ne...@confluent.io>.
+1 (binding)
On Mon, Dec 12, 2016 at 11:41 AM Guozhang Wang <wa...@gmail.com> wrote:
> +1 (binding) Thanks Xavier for the proposal !
>
> I think the source compatibility should be very rare as of now.
>
> On Mon, Dec 12, 2016 at 8:20 AM, Eno Thereska <en...@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > > On 12 Dec 2016, at 15:35, Bill Bejeck <bb...@gmail.com> wrote:
> > >
> > > +1
> > >
> > > On Mon, Dec 12, 2016 at 3:44 AM, Damian Guy <da...@gmail.com>
> > wrote:
> > >
> > >> +1
> > >>
> > >> On Sun, 11 Dec 2016 at 08:07 Ewen Cheslack-Postava <ewen@confluent.io
> >
> > >> wrote:
> > >>
> > >>> +1 (binding)
> > >>>
> > >>> My only concern was around compatibility. It seems like the one case
> it
> > >> is
> > >>> incompatible would be, at worst, an extremely unusual edge case (and
> I
> > >>> *think* can be restricted further to "not source compatible for
> anyone
> > >>> extending the affected classes / interfaces and override affected
> > >>> methods").
> > >>>
> > >>> -Ewen
> > >>>
> > >>> On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io>
> > >>> wrote:
> > >>>
> > >>>> Hi everyone,
> > >>>>
> > >>>> I would like to start the vote for KIP-100 unless there are any more
> > >>>> comments.
> > >>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > >>>> 100+-+Relax+Type+constraints+in+Kafka+Streams+API
> > >>>>
> > >>>> corresponding PR here https://github.com/apache/kafka/pull/2205
> > >>>>
> > >>>> Thanks,
> > >>>> Xavier
> > >>>>
> > >>>
> > >>
> >
> >
>
>
> --
> -- Guozhang
>
--
Thanks,
Neha
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Guozhang Wang <wa...@gmail.com>.
+1 (binding) Thanks Xavier for the proposal !
I think the source compatibility should be very rare as of now.
On Mon, Dec 12, 2016 at 8:20 AM, Eno Thereska <en...@gmail.com>
wrote:
> +1 (non-binding)
>
> > On 12 Dec 2016, at 15:35, Bill Bejeck <bb...@gmail.com> wrote:
> >
> > +1
> >
> > On Mon, Dec 12, 2016 at 3:44 AM, Damian Guy <da...@gmail.com>
> wrote:
> >
> >> +1
> >>
> >> On Sun, 11 Dec 2016 at 08:07 Ewen Cheslack-Postava <ew...@confluent.io>
> >> wrote:
> >>
> >>> +1 (binding)
> >>>
> >>> My only concern was around compatibility. It seems like the one case it
> >> is
> >>> incompatible would be, at worst, an extremely unusual edge case (and I
> >>> *think* can be restricted further to "not source compatible for anyone
> >>> extending the affected classes / interfaces and override affected
> >>> methods").
> >>>
> >>> -Ewen
> >>>
> >>> On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io>
> >>> wrote:
> >>>
> >>>> Hi everyone,
> >>>>
> >>>> I would like to start the vote for KIP-100 unless there are any more
> >>>> comments.
> >>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>>> 100+-+Relax+Type+constraints+in+Kafka+Streams+API
> >>>>
> >>>> corresponding PR here https://github.com/apache/kafka/pull/2205
> >>>>
> >>>> Thanks,
> >>>> Xavier
> >>>>
> >>>
> >>
>
>
--
-- Guozhang
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Eno Thereska <en...@gmail.com>.
+1 (non-binding)
> On 12 Dec 2016, at 15:35, Bill Bejeck <bb...@gmail.com> wrote:
>
> +1
>
> On Mon, Dec 12, 2016 at 3:44 AM, Damian Guy <da...@gmail.com> wrote:
>
>> +1
>>
>> On Sun, 11 Dec 2016 at 08:07 Ewen Cheslack-Postava <ew...@confluent.io>
>> wrote:
>>
>>> +1 (binding)
>>>
>>> My only concern was around compatibility. It seems like the one case it
>> is
>>> incompatible would be, at worst, an extremely unusual edge case (and I
>>> *think* can be restricted further to "not source compatible for anyone
>>> extending the affected classes / interfaces and override affected
>>> methods").
>>>
>>> -Ewen
>>>
>>> On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> I would like to start the vote for KIP-100 unless there are any more
>>>> comments.
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>>> 100+-+Relax+Type+constraints+in+Kafka+Streams+API
>>>>
>>>> corresponding PR here https://github.com/apache/kafka/pull/2205
>>>>
>>>> Thanks,
>>>> Xavier
>>>>
>>>
>>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Bill Bejeck <bb...@gmail.com>.
+1
On Mon, Dec 12, 2016 at 3:44 AM, Damian Guy <da...@gmail.com> wrote:
> +1
>
> On Sun, 11 Dec 2016 at 08:07 Ewen Cheslack-Postava <ew...@confluent.io>
> wrote:
>
> > +1 (binding)
> >
> > My only concern was around compatibility. It seems like the one case it
> is
> > incompatible would be, at worst, an extremely unusual edge case (and I
> > *think* can be restricted further to "not source compatible for anyone
> > extending the affected classes / interfaces and override affected
> > methods").
> >
> > -Ewen
> >
> > On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > I would like to start the vote for KIP-100 unless there are any more
> > > comments.
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 100+-+Relax+Type+constraints+in+Kafka+Streams+API
> > >
> > > corresponding PR here https://github.com/apache/kafka/pull/2205
> > >
> > > Thanks,
> > > Xavier
> > >
> >
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Damian Guy <da...@gmail.com>.
+1
On Sun, 11 Dec 2016 at 08:07 Ewen Cheslack-Postava <ew...@confluent.io>
wrote:
> +1 (binding)
>
> My only concern was around compatibility. It seems like the one case it is
> incompatible would be, at worst, an extremely unusual edge case (and I
> *think* can be restricted further to "not source compatible for anyone
> extending the affected classes / interfaces and override affected
> methods").
>
> -Ewen
>
> On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io>
> wrote:
>
> > Hi everyone,
> >
> > I would like to start the vote for KIP-100 unless there are any more
> > comments.
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 100+-+Relax+Type+constraints+in+Kafka+Streams+API
> >
> > corresponding PR here https://github.com/apache/kafka/pull/2205
> >
> > Thanks,
> > Xavier
> >
>
Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API
Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
+1 (binding)
My only concern was around compatibility. It seems like the one case it is
incompatible would be, at worst, an extremely unusual edge case (and I
*think* can be restricted further to "not source compatible for anyone
extending the affected classes / interfaces and override affected methods").
-Ewen
On Fri, Dec 9, 2016 at 10:27 AM, Xavier Léauté <xa...@confluent.io> wrote:
> Hi everyone,
>
> I would like to start the vote for KIP-100 unless there are any more
> comments.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 100+-+Relax+Type+constraints+in+Kafka+Streams+API
>
> corresponding PR here https://github.com/apache/kafka/pull/2205
>
> Thanks,
> Xavier
>