You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/03/28 23:41:18 UTC
Review Request 45400: Adapted port_mapping with missing subprocess
parameter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45400/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-5049
https://issues.apache.org/jira/browse/MESOS-5049
Repository: mesos
Description
-------
Adapted port_mapping with missing subprocess parameter.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 134b6c759b769cf335539e49eff817973c7f96a4
src/tests/containerizer/port_mapping_tests.cpp de4b6f99f3a994bcedafa801eed9c4a7b79bac23
Diff: https://reviews.apache.org/r/45400/diff/
Testing
-------
sudo make check on with port_isolator enabled.
Thanks,
Joerg Schad
Re: Review Request 45400: Adapted port_mapping with missing subprocess
parameter.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45400/#review125819
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 28, 2016, 9:41 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45400/
> -----------------------------------------------------------
>
> (Updated March 28, 2016, 9:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-5049
> https://issues.apache.org/jira/browse/MESOS-5049
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adapted port_mapping with missing subprocess parameter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 134b6c759b769cf335539e49eff817973c7f96a4
> src/tests/containerizer/port_mapping_tests.cpp de4b6f99f3a994bcedafa801eed9c4a7b79bac23
>
> Diff: https://reviews.apache.org/r/45400/diff/
>
>
> Testing
> -------
>
> sudo make check on with port_isolator enabled.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 45400: Adapted port_mapping with missing subprocess
parameter.
Posted by Cong Wang <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45400/#review125763
-----------------------------------------------------------
Ship it!
Ship It!
- Cong Wang
On March 28, 2016, 9:41 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45400/
> -----------------------------------------------------------
>
> (Updated March 28, 2016, 9:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-5049
> https://issues.apache.org/jira/browse/MESOS-5049
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adapted port_mapping with missing subprocess parameter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 134b6c759b769cf335539e49eff817973c7f96a4
> src/tests/containerizer/port_mapping_tests.cpp de4b6f99f3a994bcedafa801eed9c4a7b79bac23
>
> Diff: https://reviews.apache.org/r/45400/diff/
>
>
> Testing
> -------
>
> sudo make check on with port_isolator enabled.
>
>
> Thanks,
>
> Joerg Schad
>
>