[GitHub] [flink] slinkydeveloper edited a comment on pull request #19039: [FLINK-26582][table] Convert table modules assertions to AssertJ

[GitBox <gi...@apache.org>]

slinkydeveloper edited a comment on pull request #19039:
URL: https://github.com/apache/flink/pull/19039#issuecomment-1065194861


   @zentol I've pushed a new commit with the changes from the tool. All the unresolved comments will be resolved manually, once we agree on this output of the tool.
   
   I tried to be more conservative and now the tool doesn't try to migrate when it fails to recognize the migration patterns, for example the issue about `assertThrows` is that because of the lambdas (which are not supported by the type inference), the tool can't lookup the method and recognize whether is junit 4 or 5, hence failing to recognize which of the args is the message. Same issue applies similarly for most of hamcrest assertions.
   
   So there are less migrated files, but we should be more confident of the results now. We can always improve the tool later and re-run for those left-over classes. LMK what you think about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org