You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/06/10 15:24:57 UTC
[GitHub] [openwhisk] rabbah opened a new pull request #5130: Bump akka management api version.
rabbah opened a new pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130
<!--- Provide a concise summary of your changes in the Title -->
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah removed a comment on pull request #5130: Bump akka management api version.
Posted by GitBox <gi...@apache.org>.
rabbah removed a comment on pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130#issuecomment-859040662
In case it's cleaner, I created a separate PR just for the Mesos removal. We'll see based on feedback from dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah commented on pull request #5130: Bump akka management api version.
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130#issuecomment-859441947
The build is unhappy with the last commit. Will check into it. The mesos bit is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah commented on pull request #5130: Bump akka management api version.
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130#issuecomment-859040662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah commented on a change in pull request #5130: Bump akka management api version.
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130#discussion_r649289201
##########
File path: common/scala/build.gradle
##########
@@ -71,7 +71,7 @@ dependencies {
compile "io.kamon:kamon-datadog_${gradle.scala.depVersion}:2.1.12"
//for mesos
- compile "com.adobe.api.platform.runtime:mesos-actor:0.0.17"
+ compile "com.adobe.api.platform.runtime:mesos-actor:0.0.25"
Review comment:
this doesn't help resolve the underlying issue - i could drop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah edited a comment on pull request #5130: Bump akka management api version.
Posted by GitBox <gi...@apache.org>.
rabbah edited a comment on pull request #5130:
URL: https://github.com/apache/openwhisk/pull/5130#issuecomment-859040820
In case it's cleaner, I created a separate PR just for the Mesos removal. We'll see based on feedback from dev list. This PR might be reduced to just one or two lines if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org