You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/18 03:32:14 UTC
[kudu-CR](branch-1.11.x) [spark] Separate out DefaultSourceTests
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14505
to review the following change.
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
[spark] Separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Reviewed-on: http://gerrit.cloudera.org:8080/14491
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 930d54483a8ae850175ef1f1aff94a8f4342705f)
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/14505/1
--
To view, visit http://gerrit.cloudera.org:8080/14505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14505
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [spark] Separate out DefaultSourceTests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14505 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14505
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Oct 2019 03:36:59 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [spark] Separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14505 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
[spark] Separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Reviewed-on: http://gerrit.cloudera.org:8080/14491
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 930d54483a8ae850175ef1f1aff94a8f4342705f)
Reviewed-on: http://gerrit.cloudera.org:8080/14505
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14505
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)