You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/09 20:25:49 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #19139: Changing password as it gets masked across logs and causes issues
khalidmammadov opened a new pull request #19139:
URL: https://github.com/apache/airflow/pull/19139
Current postgres password gets masked during DB engine init and added to secret list and masked whenever mentioned in the logs.
As it currently set to "airflow" it's converted to *** everywhere airflow is printed in the logs including folder path etc.
Currently, this will fix one of the failing test cases from quarantined list that expects "airflow" path in the log but gets ***.
But this also should be noted for future similar cases as to not to name password as "airflow" or similar reserved/widely used words as they will be masked in the logs.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov closed pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
khalidmammadov closed pull request #19139:
URL: https://github.com/apache/airflow/pull/19139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-949844422
Should we unquarantine the quarantined test as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-949955438
@potiuk This PR tries to fix only 1 of 5 failing test cases within the suite and whole suite is marked as @pytest.mark.quarantined.
I didnt have chance to take a look to others so I think we can leave quarantined marker until others are also fixed.
That aside, although I am working on getting password changed everywhere it's used (which is quite a lot) I am not sure if it's ok from community perspective to do it and if they would prefer to keep as is i.e. "airflow"? In which case masking replaces airflow word with *** everywhere in the logs which will be problem I think all the time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-949844422
Should we i quarantine the quarantined test as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #19139:
URL: https://github.com/apache/airflow/pull/19139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-980786149
Closing in favor of this: https://github.com/apache/airflow/pull/19858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-949389348
This one: tests.cli.commands.test_task_command.TestLogsfromTaskRunCommand
It asserts for this value:
"INFO - Running: ['airflow', 'tasks', 'run'...."
but gets
"INFO - Running: ['***', 'tasks', 'run'..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-949966656
I see. Makes sense. I think it makes sense to change the password if it is in unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #19139: Changing password as it gets masked across logs and causes issues
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #19139:
URL: https://github.com/apache/airflow/pull/19139#issuecomment-948994862
> this will fix one of the failing test cases from quarantined list
Do you remember which one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org