[jira] [Work logged] (ARTEMIS-3916) Fix OpenWire selector with JMSMessageID

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3916?focusedWorklogId=797226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797226 ]

ASF GitHub Bot logged work on ARTEMIS-3916:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/22 13:35
            Start Date: 02/Aug/22 13:35
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4163:
URL: https://github.com/apache/activemq-artemis/pull/4163#discussion_r935603987


##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SelectorTranslator.java:
##########
@@ -54,6 +56,17 @@ public static String convertToActiveMQFilterString(final String selectorString)
 
    }
 
+   public static String convertOpenWireToActiveMQFilterString(final String selectorString) {
+      if (selectorString == null) {
+         return null;
+      }
+
+      String filterString = SelectorTranslator.convertToActiveMQFilterString(selectorString);
+      filterString = SelectorTranslator.parse(filterString, "AMQUserID", AMQ_MSG_MESSAGE_ID.toString());

Review Comment:
   We should rather make this method public than bringing OpenWire concept into commons.
   
   If it was really needed (very difficult to go around) it's ok.. but this one is easy to fix.
   
   I have the change here and I'm amending as you before merging it.





Issue Time Tracking
-------------------

            Worklog Id:     (was: 797226)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix OpenWire selector with JMSMessageID
> ---------------------------------------
>
>                 Key: ARTEMIS-3916
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3916
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)