You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/05/31 01:41:50 UTC

[GitHub] [servicecomb-java-chassis] david6969xin commented on a diff in pull request #3017: [SCB-2539] fix the fileSource configuration item does not support com…

david6969xin commented on code in PR #3017:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3017#discussion_r885140720


##########
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/ConfigCenterConfig.java:
##########
@@ -75,7 +76,12 @@ public List<String> getFileSources() {
     Object property = finalConfig.getProperty(FILE_SOURCE);
     if (property instanceof String) {
       List<String> result = new ArrayList<>();
-      result.add((String) property);
+      if (((String) property).contains(",")) {
+        String[] fileSourceNames = ((String) property).split(",");
+        result.addAll(Arrays.asList(fileSourceNames));
+      } else {
+        result.add((String) property);
+      }

Review Comment:
   yes,this code has been simplified



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org