You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2008/05/06 01:15:55 UTC
[jira] Created: (SYNAPSE-285) AbstractTransportListener doesn't
shut down its worker pool
AbstractTransportListener doesn't shut down its worker pool
-----------------------------------------------------------
Key: SYNAPSE-285
URL: https://issues.apache.org/jira/browse/SYNAPSE-285
Project: Synapse
Issue Type: Bug
Components: Transports
Reporter: Andreas Veithen
Priority: Critical
Fix For: 1.2
I would expect that a call to ServerManager#stop will cause the worker pool created by transport listeners based on AbstractTransportListener to be shut down. This is not the case.
The worker pool is created in AbstractTransportListener#init but there is no corresponding code in AbstractTransportListener#destroy to shut it down. The WorkerPool interface doesn't even define a method to shut down.
Also I was wondering whether we still need the BackportWorkerPool implementation, given that
* we target Java 1.5 and have java.util.concurrent;
* the code in BackportWorkerPool still uses classes from java.util.concurrent and therefore probably never worked on Java 1.4 (obviously nobody ever complained about this...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Assigned: (SYNAPSE-285) AbstractTransportListener doesn't
shut down its worker pool
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen reassigned SYNAPSE-285:
---------------------------------------
Assignee: Andreas Veithen
> AbstractTransportListener doesn't shut down its worker pool
> -----------------------------------------------------------
>
> Key: SYNAPSE-285
> URL: https://issues.apache.org/jira/browse/SYNAPSE-285
> Project: Synapse
> Issue Type: Bug
> Components: Transports
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Priority: Critical
> Fix For: 1.2
>
>
> I would expect that a call to ServerManager#stop will cause the worker pool created by transport listeners based on AbstractTransportListener to be shut down. This is not the case.
> The worker pool is created in AbstractTransportListener#init but there is no corresponding code in AbstractTransportListener#destroy to shut it down. The WorkerPool interface doesn't even define a method to shut down.
> Also I was wondering whether we still need the BackportWorkerPool implementation, given that
> * we target Java 1.5 and have java.util.concurrent;
> * the code in BackportWorkerPool still uses classes from java.util.concurrent and therefore probably never worked on Java 1.4 (obviously nobody ever complained about this...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-285) AbstractTransportListener doesn't
shut down its worker pool
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved SYNAPSE-285.
-------------------------------------
Resolution: Fixed
Made the necessary changes (see SVN log for details).
> AbstractTransportListener doesn't shut down its worker pool
> -----------------------------------------------------------
>
> Key: SYNAPSE-285
> URL: https://issues.apache.org/jira/browse/SYNAPSE-285
> Project: Synapse
> Issue Type: Bug
> Components: Transports
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Priority: Critical
> Fix For: 1.2
>
>
> I would expect that a call to ServerManager#stop will cause the worker pool created by transport listeners based on AbstractTransportListener to be shut down. This is not the case.
> The worker pool is created in AbstractTransportListener#init but there is no corresponding code in AbstractTransportListener#destroy to shut it down. The WorkerPool interface doesn't even define a method to shut down.
> Also I was wondering whether we still need the BackportWorkerPool implementation, given that
> * we target Java 1.5 and have java.util.concurrent;
> * the code in BackportWorkerPool still uses classes from java.util.concurrent and therefore probably never worked on Java 1.4 (obviously nobody ever complained about this...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-285) AbstractTransportListener doesn't
shut down its worker pool
Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594442#action_12594442 ]
Asankha C. Perera commented on SYNAPSE-285:
-------------------------------------------
Yes, we need to shutdown the worker pool and this is a bug, we also do not need to keep the BackportWorkerPool in the codebase anymore as we are now on JDK 1.5
> AbstractTransportListener doesn't shut down its worker pool
> -----------------------------------------------------------
>
> Key: SYNAPSE-285
> URL: https://issues.apache.org/jira/browse/SYNAPSE-285
> Project: Synapse
> Issue Type: Bug
> Components: Transports
> Reporter: Andreas Veithen
> Priority: Critical
> Fix For: 1.2
>
>
> I would expect that a call to ServerManager#stop will cause the worker pool created by transport listeners based on AbstractTransportListener to be shut down. This is not the case.
> The worker pool is created in AbstractTransportListener#init but there is no corresponding code in AbstractTransportListener#destroy to shut it down. The WorkerPool interface doesn't even define a method to shut down.
> Also I was wondering whether we still need the BackportWorkerPool implementation, given that
> * we target Java 1.5 and have java.util.concurrent;
> * the code in BackportWorkerPool still uses classes from java.util.concurrent and therefore probably never worked on Java 1.4 (obviously nobody ever complained about this...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org