You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2022/08/29 19:34:02 UTC

[sling-org-apache-sling-resource-presence] 03/04: close ResourceResolver to avoid stack trace in logs

This is an automated email from the ASF dual-hosted git repository.

olli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-resource-presence.git

commit d5b3e7f40b0319a810cd1f397dd90d8b52f002f5
Author: Oliver Lietz <ol...@apache.org>
AuthorDate: Sun Aug 28 22:36:15 2022 +0200

    close ResourceResolver to avoid stack trace in logs
---
 .../apache/sling/resource/presence/ChangeIT.java   | 45 +++++++++++-----------
 1 file changed, 23 insertions(+), 22 deletions(-)

diff --git a/src/test/java/org/apache/sling/resource/presence/ChangeIT.java b/src/test/java/org/apache/sling/resource/presence/ChangeIT.java
index 58eff4f..f6fa072 100644
--- a/src/test/java/org/apache/sling/resource/presence/ChangeIT.java
+++ b/src/test/java/org/apache/sling/resource/presence/ChangeIT.java
@@ -80,28 +80,29 @@ public class ChangeIT extends ResourcePresenterTestSupport {
         assertThat(countingServiceListener.unregisteredCount(), is(0));
 
         // create/register
-        final ResourceResolver resourceResolver = resourceResolverFactory.getAdministrativeResourceResolver(null);
-        final Resource root = resourceResolver.getResource("/");
-        final Resource test = resourceResolver.create(root, "test", null);
-        resourceResolver.commit();
-        with().
-            pollInterval(100, MILLISECONDS).
-            then().
-            await().
-            alias("counting register events").
-            atMost(1, SECONDS).
-            until(() -> countingServiceListener.registeredCount() == 1);
-
-        // delete/unregister
-        resourceResolver.delete(test);
-        resourceResolver.commit();
-        with().
-            pollInterval(100, MILLISECONDS).
-            then().
-            await().
-            alias("counting unregister events").
-            atMost(1, SECONDS).
-            until(() -> countingServiceListener.unregisteredCount() == 1);
+        try (ResourceResolver resourceResolver = resourceResolverFactory.getAdministrativeResourceResolver(null)) {
+            final Resource root = resourceResolver.getResource("/");
+            final Resource test = resourceResolver.create(root, "test", null);
+            resourceResolver.commit();
+            with().
+                pollInterval(100, MILLISECONDS).
+                then().
+                await().
+                alias("counting register events").
+                atMost(1, SECONDS).
+                until(() -> countingServiceListener.registeredCount() == 1);
+
+            // delete/unregister
+            resourceResolver.delete(test);
+            resourceResolver.commit();
+            with().
+                pollInterval(100, MILLISECONDS).
+                then().
+                await().
+                alias("counting unregister events").
+                atMost(1, SECONDS).
+                until(() -> countingServiceListener.unregisteredCount() == 1);
+        }
     }
 
     private static class CountingServiceListener implements ServiceListener {