You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/25 04:30:03 UTC

[GitHub] [hudi] n3nash commented on a change in pull request #3092: [HUDI-1910] Commit Offset to Kafka after successful Hudi commit

n3nash commented on a change in pull request #3092:
URL: https://github.com/apache/hudi/pull/3092#discussion_r658465855



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -473,7 +476,9 @@ public void refreshTimeline() throws IOException {
       boolean success = writeClient.commit(instantTime, writeStatusRDD, Option.of(checkpointCommitMetadata));
       if (success) {
         LOG.info("Commit " + instantTime + " successful!");
-
+        if (this.props.getBoolean(ENABLE_KAFKA_COMMIT_OFFSET, DEFAULT_ENABLE_KAFKA_COMMIT_OFFSET)) {

Review comment:
       @veenaypatil I think the callback approach sounds cleaner and reduces complex if-else logic in DeltaSync. Let's do that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org