[jira] [Commented] (HBASE-8695) The HBase thrift service ignores XML configuration

["Lars George (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704513#comment-13704513 ] 

Lars George commented on HBASE-8695:
------------------------------------

Hey [~b4hand], here is a patch for Thrift 1. Would you be able to test this? Also, do you need this in turnk only, or also 0.95? Or even 0.94?
                
> The HBase thrift service ignores XML configuration
> --------------------------------------------------
>
>                 Key: HBASE-8695
>                 URL: https://issues.apache.org/jira/browse/HBASE-8695
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.94.6
>         Environment: Ubuntu 12.04.2 LTS
>            Reporter: Brandon Forehand
>            Assignee: Lars George
>         Attachments: HBASE-8695.patch
>
>
> I put the following configuration in my hbase-site.xml:
> {code}
>   <property>
>     <name>hbase.regionserver.thrift.compact</name>
>     <value>true</value>
>   </property>
>   <property>
>     <name>hbase.regionserver.thrift.framed</name>
>     <value>true</value>
>   </property>
> {code}
> But the configuration is ignored due to the following lines in ThriftServer.java around lines 197:
> {code}
>     conf.setBoolean(
>         ThriftServerRunner.COMPACT_CONF_KEY, cmd.hasOption(COMPACT_OPTION));
>     conf.setBoolean(
>         ThriftServerRunner.FRAMED_CONF_KEY, cmd.hasOption(FRAMED_OPTION));
> {code}
> The configuration values are being unconditionally set to the defaults programmatically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira