You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/24 10:36:34 UTC

[GitHub] [skywalking] system-designer opened a new issue #6618: why createIndex in HistoryDeleteEsDAO#deleteHistory?

system-designer opened a new issue #6618:
URL: https://github.com/apache/skywalking/issues/6618


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - Question or discussion
   
   ___
   ### Question
   - why createIndex in HistoryDeleteEsDAO#deleteHistory?
   When chosing elasticsearch as oap-server's storage, DataTTLKeeperTimer executes HistoryDeleteEsDAO#deleteHistory every 5(default) minutes to delete expired timeseries index, this may cause heavy perfomance loss. Thus I try to set enableDataKeeperExecutor=false to disable DataTTLKeeperTimer and set index ttl on es cluster, but new index will not be created. This is because new index is only created in HistoryDeleteEsDAO#deleteHistory and in oap-server bootstrap.
   I wonder why not seperate deleteHistory and createIndex into two timers, DataTTLKeeperTimer takes responsibility for delete expired index, and a new Timer takes in charge of creating new index in elasticsearch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6618: why createIndex in HistoryDeleteEsDAO#deleteHistory?

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #6618:
URL: https://github.com/apache/skywalking/issues/6618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6618: why createIndex in HistoryDeleteEsDAO#deleteHistory?

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #6618:
URL: https://github.com/apache/skywalking/issues/6618#issuecomment-805792510


   If you have the data on a new day, a new index will be created. I am not sure how you tested this, but the index creation is not only TTL timer's responsibility


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org