Re: Review Request: Updates and additions to the MPI framework

[Harvey Feng <h....@berkeley.edu>]

> On 2012-05-31 15:42:48, Jessica wrote:
> > frameworks/mpi/mpiexec-mesos.py, line 25
> > <https://reviews.apache.org/r/4768/diff/8/?file=109962#file109962line25>
> >
> >     This is incorrect. Replace with
> >     
> >     call([MPICH2PATH + 'mpiexec', '-l', '-n', str(TOTAL_MPDS)] + MPI_PROGRAM)
> >     
> >     (note that MPI_PROGRAM is the entire program list appended to the first list)
> >     
> >     This allows MPI_PROGRAM to contain command line arguments.

Done


> On 2012-05-31 15:42:48, Jessica wrote:
> > frameworks/mpi/mpiexec-mesos.py, line 141
> > <https://reviews.apache.org/r/4768/diff/8/?file=109962#file109962line141>
> >
> >     To allow mpi_program to contain command line arguments, add the line 
> >     
> >     parser.disable_interspersed_args()
> >     
> >     (http://docs.python.org/library/optparse.html#querying-and-manipulating-your-option-parser)

Done


- Harvey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4768/#review8256
-----------------------------------------------------------


On 2012-05-23 23:44:52, Harvey Feng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4768/
> -----------------------------------------------------------
> 
> (Updated 2012-05-23 23:44:52)
> 
> 
> Review request for mesos, Benjamin Hindman, Charles Reiss, and Jessica.
> 
> 
> Summary
> -------
> 
> Some updates to point out:
> 
> -nmpiexec.py
>   -> 'mpdallexit' should terminate all slaves' mpds in the ring. I moved 'driver.stop()' to statusUpdate() so that it stops when all tasks have been finished, which occurs when the executor's launched mpd processes have all exited. 
> -startmpd.py
>   -> Didn't remove cleanup(), and added code in shutdown() that manually kills mpd processes. They might be useful during abnormal (cleanup) and normal (shutdown) framework/executor termination...I think. cleanup() still terminates all mpd's in the slave, but shutdown doesn't. 
>   -> killtask() stops the mpd associated with the given tid. 
>   -> Task states update nicely now. They correspond to the state of a task's associated mpd process.
> -Readme
>   -> Included additional info on how to setup and run MPICH2 1.2 and nmpiexec on OS X and Ubuntu/Linux
> 
> 
> This addresses bug MESOS-183.
>     https://issues.apache.org/jira/browse/MESOS-183
> 
> 
> Diffs
> -----
> 
>   frameworks/mpi/startmpd.py 8eeba5e 
>   frameworks/mpi/startmpd.sh 44faa05 
>   frameworks/mpi/nmpiexec 517bdbc 
>   frameworks/mpi/nmpiexec.py a5db9c0 
>   frameworks/mpi/mpiexec-mesos PRE-CREATION 
>   frameworks/mpi/mpiexec-mesos.py PRE-CREATION 
>   frameworks/mpi/README.txt cdb4553 
> 
> Diff: https://reviews.apache.org/r/4768/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harvey
> 
>