You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jolshan (via GitHub)" <gi...@apache.org> on 2024/05/29 23:41:49 UTC
[PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
jolshan opened a new pull request, #16130:
URL: https://github.com/apache/kafka/pull/16130
As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions.
Features is also updated to return latest production and latest testing versions of each feature.
A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready.
Adds tests for the feature usage of the unstableFeatureVersionsEnabled config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #16130:
URL: https://github.com/apache/kafka/pull/16130#issuecomment-2140914372
I filed https://issues.apache.org/jira/browse/KAFKA-16866 for the one failure and that is getting fixed separately.
As for the others, looks like they are frequent flakes. I will go ahead and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621005757
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -449,8 +449,8 @@ object KafkaConfig {
/** Internal Configurations **/
// This indicates whether unreleased APIs should be advertised by this node.
.defineInternal(ServerConfigs.UNSTABLE_API_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
- // This indicates whether unreleased MetadataVersions should be enabled on this node.
- .defineInternal(ServerConfigs.UNSTABLE_METADATA_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
+ // This indicates whether unreleased MetadataVersions or other feature versions should be enabled on this node.
+ .defineInternal(ServerConfigs.UNSTABLE_FEATURE_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
Review Comment:
Yeah, it's a fair question. I think the original intent was to keep it internal and only use for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621089819
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -354,6 +354,7 @@ Found problem:
MetadataVersion.LATEST_PRODUCTION,
Map(TestFeatureVersion.FEATURE_NAME -> featureLevel),
allFeatures,
+ false,
Review Comment:
`if (featureLevel <= Features.TEST_VERSION.defaultValue(MetadataVersion.LATEST_PRODUCTION))` this means we skip version 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621463208
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -449,8 +449,8 @@ object KafkaConfig {
/** Internal Configurations **/
// This indicates whether unreleased APIs should be advertised by this node.
.defineInternal(ServerConfigs.UNSTABLE_API_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
- // This indicates whether unreleased MetadataVersions should be enabled on this node.
- .defineInternal(ServerConfigs.UNSTABLE_METADATA_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
+ // This indicates whether unreleased MetadataVersions or other feature versions should be enabled on this node.
+ .defineInternal(ServerConfigs.UNSTABLE_FEATURE_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
Review Comment:
Yup -- this is the text in the KIP:
> Add INTERNAL configuration unstable.feature.versions.enable to allow for non production ready features to be used (for testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #16130:
URL: https://github.com/apache/kafka/pull/16130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1620747107
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -449,8 +449,8 @@ object KafkaConfig {
/** Internal Configurations **/
// This indicates whether unreleased APIs should be advertised by this node.
.defineInternal(ServerConfigs.UNSTABLE_API_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
- // This indicates whether unreleased MetadataVersions should be enabled on this node.
- .defineInternal(ServerConfigs.UNSTABLE_METADATA_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
+ // This indicates whether unreleased MetadataVersions or other feature versions should be enabled on this node.
+ .defineInternal(ServerConfigs.UNSTABLE_FEATURE_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH)
Review Comment:
Do we want to keep it internal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on code in PR #16130:
URL: https://github.com/apache/kafka/pull/16130#discussion_r1621034615
##########
server-common/src/main/java/org/apache/kafka/server/common/Features.java:
##########
@@ -76,16 +76,21 @@ public short latestProduction() {
return defaultValue(MetadataVersion.LATEST_PRODUCTION);
}
+ public short latestTesting() {
+ return featureVersions[featureVersions.length - 1].featureLevel();
+ }
+
/**
* Creates a FeatureVersion from a level.
*
* @param level the level of the feature
* @return the FeatureVersionUtils.FeatureVersion for the feature the enum is based on.
* @throws IllegalArgumentException if the feature is not known.
*/
- public FeatureVersion fromFeatureLevel(short level) {
+ public FeatureVersion fromFeatureLevel(short level,
+ boolean allowUnstableFeatureVersions) {
Review Comment:
Could we add the new param to javadoc?
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -354,6 +354,7 @@ Found problem:
MetadataVersion.LATEST_PRODUCTION,
Map(TestFeatureVersion.FEATURE_NAME -> featureLevel),
allFeatures,
+ false,
Review Comment:
Hmm, TEST_VERSION level 2 is not in production and should show an exception when calling `StorageTool.generateFeatureRecord`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org