You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "joazco (via GitHub)" <gi...@apache.org> on 2025/03/07 14:09:36 UTC

[PR] Issue/debug capacitor [cordova-plugin-media]

joazco opened a new pull request, #404:
URL: https://github.com/apache/cordova-plugin-media/pull/404

   ### Platforms affected
   All platforms supported by the Cordova Media plugin.
   
   ### Motivation and Context
   This change ensures that when `cordova.platformId` is not defined (e.g., running under Capacitor), the plugin falls back to `Capacitor.getPlatform()` for platform detection.
   
   ### Description
   - Added a small code snippet in `Media.js` to check if `cordova.platformId` is undefined.
   - If it is, the plugin now uses `Capacitor.getPlatform()` to identify the active platform.
   
   ### Testing
   - Tested on Android and iOS through a Capacitor project to confirm that audio playback still works and the platform is correctly identified.
   
   ### Checklist
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(android)` or `(ios)` if it specifically applies to one platform
   - [x] This Pull Request resolves an issue or adds functionality (no open issues linked)
   - [x] I've updated the documentation if necessary


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] Issue/debug capacitor [cordova-plugin-media]

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek closed pull request #404: Issue/debug capacitor
URL: https://github.com/apache/cordova-plugin-media/pull/404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] Issue/debug capacitor [cordova-plugin-media]

Posted by "joazco (via GitHub)" <gi...@apache.org>.
joazco commented on PR #404:
URL: https://github.com/apache/cordova-plugin-media/pull/404#issuecomment-2737661527

   Okay, no worries. I’ve forked the project for those who want to use the plugin with Capacitor: https://github.com/joazco/cordova-plugin-media


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] Issue/debug capacitor [cordova-plugin-media]

Posted by "scr2em (via GitHub)" <gi...@apache.org>.
scr2em commented on PR #404:
URL: https://github.com/apache/cordova-plugin-media/pull/404#issuecomment-2738010498

   For anyone coming here, I have fixed it in Capacitor and they released it as 7.1.0 
   https://github.com/ionic-team/capacitor/pull/7902
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] Issue/debug capacitor [cordova-plugin-media]

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #404:
URL: https://github.com/apache/cordova-plugin-media/pull/404#issuecomment-2706623380

   Apache Cordova base should have zero references to Capacitor, and certainly a plugin should not be manipulating `platformId`
   
   It's Capacitor's responsibility to set requires cordova fields and objects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org