You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-dev@apache.org by serranom <gi...@git.apache.org> on 2016/08/10 00:28:02 UTC
[GitHub] incubator-twill pull request #83: TWILL-182, make jar name unique when creat...
GitHub user serranom opened a pull request:
https://github.com/apache/incubator-twill/pull/83
TWILL-182, make jar name unique when creating bundle
These code changes add a test for the same jar issue and update the jar name saved to the bundle if it is no longer unique. To uniquify the name, parts of the path are progressively prefixed onto the original name. We know at some point the full path is unique (because it is present in a set) so eventually the prepending must end up with a unique jar name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serranom/incubator-twill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 0ae5df6cb21d1eede4482615fb07cc4870df5c73
Author: martin <ma...@attivio.com>
Date: 2016-08-09T19:21:30Z
TWILL-182, failing test which demonstrates issue
commit 2208baa4ece8c947e0e6b9320d635376ecbed7ff
Author: martin <ma...@attivio.com>
Date: 2016-08-10T00:10:56Z
TWILL-181, uniquify included jars by using dir names
commit 01623e81137215db2d188a1fb6f7c98acdce483f
Author: martin <ma...@attivio.com>
Date: 2016-08-10T00:15:43Z
TWILL-181, fix warnings for style
commit 1bc367b459cf97f5d92391b89164c4f0baeac7ee
Author: martin <ma...@attivio.com>
Date: 2016-08-10T00:18:54Z
Merge commit '0ae5df6'
commit 421e0f44f592a992a374500537b4c42d9c32a180
Author: martin <ma...@attivio.com>
Date: 2016-08-10T00:20:06Z
Merge commit '2208baa'
commit a6cfceb6c4db6e5e8daab953f4dae9ae5995db3a
Author: martin <ma...@attivio.com>
Date: 2016-08-10T00:20:20Z
Merge commit '01623e8'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill issue #83: TWILL-182, make jar name unique when creating bun...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the issue:
https://github.com/apache/incubator-twill/pull/83
I am sorry for the trouble, but could you move the PR to our new Github mirror: https://github.com/apache/twill
The mirror will go away in the next ASF infra mirror refresh.
I will send email to dev@ list for announcement. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---