You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/25 21:47:00 UTC
Review Request 25033: Fixed MesosContainerizer to reject tasks that
have ContainerInfo set.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25033/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Bugs: MESOS-1732
https://issues.apache.org/jira/browse/MESOS-1732
Repository: mesos-git
Description
-------
Fixed MesosContainerizer to reject tasks that have ContainerInfo set.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/25033/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 25033: Fixed MesosContainerizer to reject tasks
that have ContainerInfo set.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25033/#review51435
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25033/#comment89753>
Do you want to check executorInfo.container as well here?
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/25033/#comment89752>
Remove this LOG(INFO)? If one uses --containerizers=mesos,docker, you will see this log line all over the place
- Jie Yu
On Aug. 25, 2014, 7:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25033/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 7:47 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-1732
> https://issues.apache.org/jira/browse/MESOS-1732
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed MesosContainerizer to reject tasks that have ContainerInfo set.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/25033/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 25033: Fixed MesosContainerizer to reject tasks
that have ContainerInfo set.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25033/#review51463
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 25, 2014, 11:35 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25033/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:35 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-1732
> https://issues.apache.org/jira/browse/MESOS-1732
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed MesosContainerizer to reject tasks that have ContainerInfo set.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/25033/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 25033: Fixed MesosContainerizer to reject tasks
that have ContainerInfo set.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25033/#review51464
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 25, 2014, 11:35 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25033/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:35 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-1732
> https://issues.apache.org/jira/browse/MESOS-1732
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed MesosContainerizer to reject tasks that have ContainerInfo set.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/25033/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 25033: Fixed MesosContainerizer to reject tasks
that have ContainerInfo set.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25033/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:35 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Changes
-------
jie's
Bugs: MESOS-1732
https://issues.apache.org/jira/browse/MESOS-1732
Repository: mesos-git
Description
-------
Fixed MesosContainerizer to reject tasks that have ContainerInfo set.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/25033/diff/
Testing
-------
make check
Thanks,
Vinod Kone